From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 407E7C2D0DB for ; Fri, 31 Jan 2020 16:28:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 117FF214D8 for ; Fri, 31 Jan 2020 16:28:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Hq9oGDGl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726604AbgAaQ21 (ORCPT ); Fri, 31 Jan 2020 11:28:27 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:60336 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726168AbgAaQ20 (ORCPT ); Fri, 31 Jan 2020 11:28:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Gg4n82nFEGI/sYDjX2Y3BWaIREh/CzsvHXg7cg78LlE=; b=Hq9oGDGlX1a78c8stzsviEv0m2 m0svDk0afLBmXZGKqTYlsfWvPQ/IycHZo0b/bDYaiSgedtESdLv44Indo9DsaMBB5nZM/cYzZYsBV 6c2P9bbDgP+TtLAalb/PLFFE27rrwtGHfubSdlBidZEmaa1vNOErEq1/QWUdbVswwJok=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1ixZ9S-0008EI-Sv; Fri, 31 Jan 2020 17:28:14 +0100 Date: Fri, 31 Jan 2020 17:28:14 +0100 From: Andrew Lunn To: Calvin Johnson Cc: linux.cj@gmail.com, Jon Nettleton , linux@armlinux.org.uk, Makarand Pawagi , cristian.sovaiala@nxp.com, laurentiu.tudor@nxp.com, ioana.ciornei@nxp.com, V.Sethi@nxp.com, pankaj.bansal@nxp.com, "Rajesh V . Bikkina" , Marcin Wojtas , Calvin Johnson , "David S. Miller" , Florian Fainelli , Heiner Kallweit , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1 1/7] mdio_bus: Introduce fwnode MDIO helpers Message-ID: <20200131162814.GB17185@lunn.ch> References: <20200131153440.20870-1-calvin.johnson@nxp.com> <20200131153440.20870-2-calvin.johnson@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200131153440.20870-2-calvin.johnson@nxp.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 31, 2020 at 09:04:34PM +0530, Calvin Johnson wrote: > From: Marcin Wojtas > > This patch introduces fwnode helper for registering MDIO > bus, as well as one for finding the PHY, basing on its > firmware node pointer. Comparing to existing OF equivalent, > fwnode_mdiobus_register() does not support: > * deprecated bindings (device whitelist, nor the PHY ID embedded > in the compatible string) > * MDIO bus auto scanning > > Signed-off-by: Marcin Wojtas > Signed-off-by: Calvin Johnson Hi Calvin This appears to but a cut and paste, follow by an intelligent s/of/fwnode/g. Did you make any attempt to consolidate the two implementations? It seems like there should be some level of abstraction that hides away the difference between DT properties, and DT properties stuffed into ACPI tables? Andrew