From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DATE_IN_PAST_24_48, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA278C3F68F for ; Sun, 2 Feb 2020 12:01:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A25A120679 for ; Sun, 2 Feb 2020 12:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580644864; bh=Um8ivH7g20wtXljlgKrIH7faH5C60MhCaawtKglnJ3E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qBX4o5fvxey1PDih1C+nVCcXaoAhdY/UTRFSxzyc9SuUCJ1pj58tM2YyA18l+5/ur BIjS9jd3Q7EjfdqDsF5xVNS3YjoFNuIrOxNonosieofZrzuyj5vk3QPeSEiYKn0yDm Leh0JlvPtABRpznD4BTBz2jH5IUWyLE46TQdMy+k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726987AbgBBMAs (ORCPT ); Sun, 2 Feb 2020 07:00:48 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:57122 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726907AbgBBMAr (ORCPT ); Sun, 2 Feb 2020 07:00:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=h7E2UaKOVX1aD/zQdXr3brFbm+K+Dp4X6pCQvTffYRk=; b=OfVWWu0JCHbYAyfezgu1tH+VP xnqyb0yrlt9o5GwiUYRZObeQlGr4HN0MI+HmlZupvtTnAYJd1YVDWXosXbexKO+LeY48Xgik2/mGi 3SbPaPtnQ3MPhs5Scu6FapchiQk260HBaBZrJ9GulAt3Cyvf8aMXnkcdPAsztDgl6bAGc=; Received: from [151.216.144.116] (helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iyDvT-0006po-EI; Sun, 02 Feb 2020 12:00:31 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 6E272D01A54; Sat, 1 Feb 2020 11:32:50 +0000 (GMT) Date: Sat, 1 Feb 2020 11:32:50 +0000 From: Mark Brown To: Andy Shevchenko Cc: John Garry , chenxiang66@hisilicon.com, Linux Kernel Mailing List , liusimin4@huawei.com, Linuxarm , linux-spi , Marek Vasut , "open list:MEMORY TECHNOLOGY..." , tudor.ambarus@microchip.com, Jiancheng Xue , Mika Westerberg , wanghuiqiang , fengsheng5@huawei.com Subject: Re: [PATCH v2 2/3] spi: Add HiSilicon v3xx SPI NOR flash controller driver Message-ID: <20200201113250.GT3897@sirena.org.uk> References: <20200113114256.GH3897@sirena.org.uk> <6dd45da9-9ccf-45f7-ed12-8f1406a0a56b@huawei.com> <20200113140627.GJ3897@sirena.org.uk> <20200113142754.GL3897@sirena.org.uk> <20200113143403.GQ32742@smile.fi.intel.com> <0252a76d-7e2b-2c70-8b1b-0d041d972098@huawei.com> <136bd652-dcb9-3efa-a92f-2263cbf840ad@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fDWuavwabVZ6mXOJ" Content-Disposition: inline In-Reply-To: X-Cookie: Programming is an unnatural act. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fDWuavwabVZ6mXOJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 31, 2020 at 05:46:39PM +0200, Andy Shevchenko wrote: > On Fri, Jan 31, 2020 at 2:03 PM John Garry wrote: > > On 31/01/2020 11:39, Andy Shevchenko wrote: > > > DataBitLength is the size, in bits, of the smallest transfer unit for > > > this connection. _LEN is automatically > > > created to refer to this portion of the resource descriptor. > > > Is it what you are looking for? (As far as I know most of the > > > firmwares simple abuse this field among others) > > I didn't think so - I thought that there was a distinction between width > > and length in SPI terms. > My interpretation of this field is a data width of the slave. > Basically what we have as transfer->size inside SPI in the Linux > kernel. This discussion is about the number of data lines, SPI_TX_QUAD and friends. > 1 SpiSerialBusV2(0x0000,PolarityLow,FourWireMode,0x08, > 36 SpiSerialBusV2(0x0000,PolarityLow,FourWireMode,0x10, > 35 SpiSerialBusV2(0x0000,PolarityLow,FourWireMode,0x18, > 35 SpiSerialBusV2(0x0000,PolarityLow,FourWireMode,0x20, > 1 SpiSerialBusV2(0x0000,PolarityLow,ThreeWireMode,0x10, > 8 SpiSerialBusV2(0x0001,PolarityLow,FourWireMode,0x08, > 1 SpiSerialBusV2(0x0001,PolarityLow,FourWireMode,0x10, > So, it seems I stand corrected, the field is in right use, although > cases like 0x10 and 0x20 should be carefully checked. Those look like they're mainly controlling SPI_3WIRE so it does look like a reasonable fit, yes. --fDWuavwabVZ6mXOJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl41YeEACgkQJNaLcl1U h9C+bQf9H0e8FvkTjz4ZUrRo0CSS5uWHyG8Ip87aiypFpHhI6CUAyHdGFwyLCrr9 EE93J+iOOuXq/xO7PMU5mD5LQ5MJlOUeOEeUHvldsQg6snP76Cf4U0U3RIifoBe8 tNMlneq9czEifmRnptwx0MFaW03kpgeX68wYT3p5HuWtjyOfrVOwk3jiz9PSR5BJ oPwOWzvyBKskSYYXGDtuHMtFqM9SjobrbHHK6rWlmr5xAqOUXAyRBTX22PYI5hi9 r45kq+3FL3V0ayJZi5jZT5+VZsXCsUC41cwacJpl0aIUp7YRm+Xv1SV644y82AyW B8pYHbZNJ2tpXjEJOH38LZ94cRYOJg== =OiRO -----END PGP SIGNATURE----- --fDWuavwabVZ6mXOJ--