From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45825C35247 for ; Mon, 3 Feb 2020 18:39:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 133D62086A for ; Mon, 3 Feb 2020 18:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580755157; bh=MZADIRrK5vab8PxK9EWlQo33bsfzGlynG26Gj3Li+mM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=XBr10MQQP0SXpShZ//B8LHQiy7ljNBTogz9VexxnGeIC3d3qNMy5AXxT9dr0OLnVo rHOHjan9TZ3uwFIL9jbQfjoTxlNraiRgltLfDnJN7Uhx4sMJiviXWZ9UBHsBOgLO5M 9SAesXGiBvD4Q2teQ0BJV8sjZ7yOYd8DhBNbf3W4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729292AbgBCSjQ (ORCPT ); Mon, 3 Feb 2020 13:39:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:37868 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726930AbgBCSjQ (ORCPT ); Mon, 3 Feb 2020 13:39:16 -0500 Received: from cakuba.hsd1.ca.comcast.net (unknown [199.201.64.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5ACD720721; Mon, 3 Feb 2020 18:39:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580755155; bh=MZADIRrK5vab8PxK9EWlQo33bsfzGlynG26Gj3Li+mM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QK+3zjAAIpgOgs2WyTkpMRnLVhrkwH5f0ztH1uh5fXqY38sJ6Xe3yaI9R3FsraBXK ic2FMLcho93dGWq1H/qRI+BHSoPIpBR+zUG8caXYL6tXLeXsODYO9wl0hRBjz/GrPF OhTzv/aGcGbspM8sctT2+ySZJCrJkxR8SN2ZsJAw= Date: Mon, 3 Feb 2020 10:39:14 -0800 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 0/4] rxrpc: Fixes ver #2 Message-ID: <20200203103914.4b038cb7@cakuba.hsd1.ca.comcast.net> In-Reply-To: <158072584492.743488.4616022353630142921.stgit@warthog.procyon.org.uk> References: <158072584492.743488.4616022353630142921.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 03 Feb 2020 10:30:45 +0000, David Howells wrote: > Here are a number of fixes for AF_RXRPC: > > (1) Fix a potential use after free in rxrpc_put_local() where it was > accessing the object just put to get tracing information. > > (2) Fix insufficient notifications being generated by the function that > queues data packets on a call. This occasionally causes recvmsg() to > stall indefinitely. > > (3) Fix a number of packet-transmitting work functions to hold an active > count on the local endpoint so that the UDP socket doesn't get > destroyed whilst they're calling kernel_sendmsg() on it. > > (4) Fix a NULL pointer deref that stemmed from a call's connection pointer > being cleared when the call was disconnected. > > Changes: > > v2: Removed a couple of BUG() statements that got added. > > The patches are tagged here: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-fixes-20200130 Thank you David! I pulled rxrpc-fixes-20200202 since that tag seems to correspond to the patches on the mailing list. Should I queue these for stable? There are some fixes to fixes here, so AFAIK we need: 5273a191dca65a675dc0bcf3909e59c6933e2831 4.9+ 04d36d748fac349b068ef621611f454010054c58 4.19+ f71dbf2fb28489a79bde0dca1c8adfb9cdb20a6b 4.9+ fac20b9e738523fc884ee3ea5be360a321cd8bad 4.19+