From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D710CC35247 for ; Mon, 3 Feb 2020 14:32:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5BB820CC7 for ; Mon, 3 Feb 2020 14:32:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728430AbgBCOcd (ORCPT ); Mon, 3 Feb 2020 09:32:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:46236 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727649AbgBCOcc (ORCPT ); Mon, 3 Feb 2020 09:32:32 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 66D0AB213; Mon, 3 Feb 2020 14:32:30 +0000 (UTC) Date: Mon, 3 Feb 2020 15:32:28 +0100 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Christian Brauner Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , Oleg Nesterov , Ingo Molnar , Johannes Weiner , Li Zefan , Peter Zijlstra , cgroups@vger.kernel.org Subject: Re: [PATCH v5 5/6] clone3: allow spawning processes into cgroups Message-ID: <20200203143228.GC13360@blackbody.suse.cz> References: <20200121154844.411-1-christian.brauner@ubuntu.com> <20200121154844.411-6-christian.brauner@ubuntu.com> <20200129132719.GD11384@blackbody.suse.cz> <20200202093702.cdlyytywty7hk3rn@wittgenstein> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iFRdW5/EC4oqxDHL" Content-Disposition: inline In-Reply-To: <20200202093702.cdlyytywty7hk3rn@wittgenstein> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --iFRdW5/EC4oqxDHL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Feb 02, 2020 at 10:37:02AM +0100, Christian Brauner wrote: > cgroup_post_fork() is called past the point of no return for fork and > cgroup_css_set_put_fork() is explicitly documented as only being > callable before forks point of no return: I missed this and somehow incorrectly assumed it's called at the end of fork too. I find the css_set refcounting correct now. BTW any reason why not to utilize cgroup_css_set_put_fork() for the regular cleanup in cgroup_post_fork() too? Thanks, Michal --iFRdW5/EC4oqxDHL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEEoQaUCWq8F2Id1tNia1+riC5qSgFAl44LvcACgkQia1+riC5 qSih0g//dEMA5UJIbc+0y7DXE9E+SiqXkYhkYbIoloeRHoNZZnwezyhercYrcOya 1yJzJ0H9zz9i3gQ3A5VE/Aqp9/gqjRakmtpLg3HNFO7gEFv3l9Mn5YwP0HEWIa3v BOCCmdKlCFjMl41ZqsHjqnFYpNosVV/NP946BsTdN3zmDpRHLZLMTPz06CGrfvoB vxE1Rbwn155YhwSmTQc2jBEhswXCs1LR7Y992a4aTOcvtTDGJafX3B4hbEPjQsRs aIjE1nbF/WB0giyfyw6UjBt+VI/1DYh9+wHNrbctlCufSi+r+ideubGqH027vgnb UNynOqSoBOcTdbI7O7ON69Ir7eB9itrsEGp6H+SqBMqPrxt8ZaVTjA6EFKrX99ST ypg27IRkSSufIk9JMnIBCMOAXmU2SxlCJk5imkyS8ghOoZcI9VlnS4jDh5IHlSm+ 25L9thnO+QjtfGXYQhtddSPBYTa5tdN23/SigWvuvumWBOMEIpBqxndH4gv658Lz vo4OnmpAWuT400Tt/YZF1HX0gCDWLPlYz+nA9VXn7aMyzMPZdIVqjFAuY35OXZyF 8mwQdWPdyKeOXjfbQoiSqbTsR/mEDGUCbbf5v+bxI2vvJsBz+otzUGT8MKqPEC6c lFvB9fnlI7rZ1x4lCoy+fqtIJfoLvuZq9pSx38U/O20H3siWH08= =Y692 -----END PGP SIGNATURE----- --iFRdW5/EC4oqxDHL--