From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 198FFC3524D for ; Mon, 3 Feb 2020 17:49:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA9FF2086A for ; Mon, 3 Feb 2020 17:49:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rJLh2L/J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728821AbgBCRtm (ORCPT ); Mon, 3 Feb 2020 12:49:42 -0500 Received: from mail-pj1-f66.google.com ([209.85.216.66]:54324 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727314AbgBCRtl (ORCPT ); Mon, 3 Feb 2020 12:49:41 -0500 Received: by mail-pj1-f66.google.com with SMTP id dw13so73888pjb.4; Mon, 03 Feb 2020 09:49:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VFIHct8h7RIoSFqhED+o/Azmguq6Ly7hEHelGB4W9mA=; b=rJLh2L/JEaA6qndkElyMttwtnyOOcFo960BcBRtEhli7f+n5Htup9fOrk7dDrf71b9 bwKcPMeuY0GzMnuUsXSrcI1exWFWvfuLcD6cbbJyrrkS5Fs91/MHqci/eA1F9l5GDlav C+JhNAubnuJ1c84qw7UqStwYFixG+SBAbDrdXPoTIfH59gPPfbgjjQ/RqD3Dx3fD/zQk EIP8SiwqlEIFSTodreMH1vbNTpjlpO8jc/hT1/DGjqZWOlqn/zmZnISvcuNzJRt3beFC GVt/ON72eBuasAWL/wUc/RuThDZUfxMgXJ2SsRUNVqhb0evzm3IKAbFEAzLA+6naeFrJ alkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=VFIHct8h7RIoSFqhED+o/Azmguq6Ly7hEHelGB4W9mA=; b=gYW7iAt9VvhXhk62shGrLWh/+SKhAwRwyN+Z+hQHR4TeSFDrkS+Z1PKWX0c2w/uP2R 4DcCjDAvsHqgFXtJ9dekPx3f0D8EVGjvzmwtzUzkeaRV7ikwcbMGzNazvN0yebhslE0M tATuKydAh1QJakmfgroAsQNMFRRO56mwJtW5Ve70iqUQw405eF1r10yLRylvB5GqeD4x /nf5aN7K7SIQ/XODST1YeJG2S88IZ3e5TgQHcxUGOrDrpvbnaWmwy8zqcEdU74mnmFSN LpIU9XZkKAx9LspuvkmsThBbVbRr19G6Bx5we5A5JeMavUlTqm17vjUkCiiripZ/de5d 7IdA== X-Gm-Message-State: APjAAAVpL1+ex89bA6Hm6xZvKbzlKB8ckQKO+mgtDgkqwDfKutuHY+eI EMaRxTkNEPHDctw6Etskxww= X-Google-Smtp-Source: APXvYqwjIumHE4pR9pnVMujFPGFWpCGP5BbojLG8Sb/TuKcHjQDsDGAkmB4Q9MYtN8sRZVHvt9LVgA== X-Received: by 2002:a17:902:a984:: with SMTP id bh4mr25180238plb.281.1580752179633; Mon, 03 Feb 2020 09:49:39 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id j8sm97701pjb.4.2020.02.03.09.49.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Feb 2020 09:49:38 -0800 (PST) Date: Mon, 3 Feb 2020 09:49:37 -0800 From: Guenter Roeck To: Randy Dunlap Cc: LKML , "linux-watchdog@vger.kernel.org" , "wim@linux-watchdog.org" , Matthias Brugger Subject: Re: [PATCH -next] watchdog: fix mtk_wdt.c RESET_CONTROLLER build error Message-ID: <20200203174937.GA18628@roeck-us.net> References: <77c1e557-4941-3806-2933-6c3583576390@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77c1e557-4941-3806-2933-6c3583576390@infradead.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 03, 2020 at 08:10:29AM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build error when CONFIG_RESET_CONTROLLER is not set by > selecting RESET_CONTROLLER. > > ld: drivers/watchdog/mtk_wdt.o: in function `mtk_wdt_probe': > mtk_wdt.c:(.text+0x3ec): undefined reference to `devm_reset_controller_register' > > Signed-off-by: Randy Dunlap > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Cc: Matthias Brugger > Cc: linux-watchdog@vger.kernel.org Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20200203.orig/drivers/watchdog/Kconfig > +++ linux-next-20200203/drivers/watchdog/Kconfig > @@ -841,6 +841,7 @@ config MEDIATEK_WATCHDOG > tristate "Mediatek SoCs watchdog support" > depends on ARCH_MEDIATEK || COMPILE_TEST > select WATCHDOG_CORE > + select RESET_CONTROLLER > help > Say Y here to include support for the watchdog timer > in Mediatek SoCs. > >