From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EA78C2D0B1 for ; Tue, 4 Feb 2020 11:44:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CA182084E for ; Tue, 4 Feb 2020 11:44:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727207AbgBDLo6 (ORCPT ); Tue, 4 Feb 2020 06:44:58 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:42208 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727030AbgBDLo6 (ORCPT ); Tue, 4 Feb 2020 06:44:58 -0500 Received: from localhost (unknown [IPv6:2001:982:756:1:57a7:3bfd:5e85:defb]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BD1C8133A87D3; Tue, 4 Feb 2020 03:44:56 -0800 (PST) Date: Tue, 04 Feb 2020 12:44:55 +0100 (CET) Message-Id: <20200204.124455.1858606436930758654.davem@davemloft.net> To: tbogendoerfer@suse.de Cc: ralf@linux-mips.org, paulburton@kernel.org, linux-mips@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: sgi: ioc3-eth: Remove leftover free_irq() From: David Miller In-Reply-To: <20200204113628.13654-1-tbogendoerfer@suse.de> References: <20200204113628.13654-1-tbogendoerfer@suse.de> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 04 Feb 2020 03:44:57 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Bogendoerfer Date: Tue, 4 Feb 2020 12:36:28 +0100 > Commit 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") moved > request_irq() from ioc3_open into probe function, but forgot to remove > free_irq() from ioc3_close. > > Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") > Signed-off-by: Thomas Bogendoerfer ioc3_open() still has the request_irq() in my tree.