From: Steven Rostedt <rostedt@goodmis.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: Amol Grover <frextrite@gmail.com>, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH] tracing: Annotate ftrace_graph_hash pointer with __rcu
Date: Tue, 4 Feb 2020 05:02:29 -0500 [thread overview]
Message-ID: <20200204050229.70e2cb0e@oasis.local.home> (raw)
In-Reply-To: <20200203163301.GB85781@google.com>
On Mon, 3 Feb 2020 11:33:01 -0500
Joel Fernandes <joel@joelfernandes.org> wrote:
> > preempt_disable_notrace();
> >
> > - if (ftrace_hash_empty(ftrace_graph_hash)) {
> > + hash = rcu_dereference_protected(ftrace_graph_hash, !preemptible());
>
> I think you can use rcu_dereference_sched() here? That way no need to pass
> !preemptible.
>
> A preempt-disabled section is an RCU "sched flavor" section. Flavors are
> consolidated in the backend, but in the front end the dereference API still
> do have flavors.
Agreed, Amol, can you send an update?
-- Steve
next prev parent reply other threads:[~2020-02-04 10:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 7:27 Amol Grover
2020-02-03 16:33 ` Joel Fernandes
2020-02-04 10:02 ` Steven Rostedt [this message]
2020-02-05 1:01 ` Steven Rostedt
2020-02-05 5:26 ` Amol Grover
2020-02-05 13:11 ` Paul E. McKenney
2020-02-05 13:14 ` Steven Rostedt
2020-02-05 13:19 ` Steven Rostedt
2020-02-05 13:29 ` Paul E. McKenney
2020-02-05 22:06 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204050229.70e2cb0e@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=frextrite@gmail.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhuparnabhowmik10@gmail.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome