From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ADCCC35247 for ; Tue, 4 Feb 2020 19:32:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE8F82087E for ; Tue, 4 Feb 2020 19:32:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nfrJpMl/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727620AbgBDTcA (ORCPT ); Tue, 4 Feb 2020 14:32:00 -0500 Received: from mail-pj1-f66.google.com ([209.85.216.66]:39729 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727445AbgBDTb4 (ORCPT ); Tue, 4 Feb 2020 14:31:56 -0500 Received: by mail-pj1-f66.google.com with SMTP id e9so1833200pjr.4 for ; Tue, 04 Feb 2020 11:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3mnXL4mq5RnnUrdKt8dTqwe0mdqkGu5G0RBIoNNOFIY=; b=nfrJpMl/NkXlXm1zwccGpX9nj3v7gheq6vapei2v1UBO/c34zZsr1OSdTykjwa9swb qg2aLP8dXGGFTsiErSDN9rLfFUyI5z4YmQ7SqAPHdRVHD4IdZsMHEc2jvNZUyGBdBbOB +KsEwSFp1bI4RClMbjKwtR/zXcSt5/PTy8ewM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3mnXL4mq5RnnUrdKt8dTqwe0mdqkGu5G0RBIoNNOFIY=; b=aKT7irHMdTNH3Aq8LFK8SlaC3ToLgYWclcs2Lv9uBQH88Y/iqM6sFnxhEkwRAnU3ho DhnOKkADPt3ynEtIy4PEFzStrGFLKrABKytb5pXa3srCo9P2cDJb/oUzvH/Hvh5cj2Zb q1P3ADO5PkL1r524pwu+lBbkl5h49j6CB9KWR1kULKho0eBsHeqIBp+hUAhRK2W3dAB0 T/Fa4tlGWIKJ0xbF4gbahnTjhIIIckYkMB2nzI2AXLb1hBQW5QlzgsJH9MTl2ELOMua4 CaDosEWIfwrS0zK8BU36hP9PjQFU/l6wjNq79owCqdm4T2GfUh6Cu5tUMUWnirriYeyV 8jXQ== X-Gm-Message-State: APjAAAUZMIXvd9lP0t0HN3PDqCyt/er3JqsMlERSIeuqR7xsJaUcfQe9 4cOxv6r34vD/dNQyf0WXZlgx2A== X-Google-Smtp-Source: APXvYqyO0lAh0JwBo+F40bj/gsmfbuZTVv1MHdOvKM6UesYAvtPuFBuzPvM6XvbXaZy87J57mdPGSA== X-Received: by 2002:a17:90a:cb83:: with SMTP id a3mr842308pju.80.1580844715239; Tue, 04 Feb 2020 11:31:55 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id g18sm24956626pfi.80.2020.02.04.11.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2020 11:31:53 -0800 (PST) From: Stephen Boyd To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, Girish Mahadevan , Dilip Kota , Alok Chauhan , Douglas Anderson Subject: [PATCH 1/3] i2c: qcom-geni: Let firmware specify irq trigger flags Date: Tue, 4 Feb 2020 11:31:50 -0800 Message-Id: <20200204193152.124980-2-swboyd@chromium.org> X-Mailer: git-send-email 2.25.0.341.g760bfbb309-goog In-Reply-To: <20200204193152.124980-1-swboyd@chromium.org> References: <20200204193152.124980-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't need to force IRQF_TRIGGER_HIGH here as the DT or ACPI tables should take care of this for us. Just use 0 instead so that we use the flags from the firmware. Also, remove specify dev_name() for the irq name so that we can get better information in /proc/interrupts about which device is generating interrupts. Cc: Girish Mahadevan Cc: Dilip Kota Cc: Alok Chauhan Cc: Douglas Anderson Signed-off-by: Stephen Boyd --- drivers/i2c/busses/i2c-qcom-geni.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index 17abf60c94ae..3e13b54ce3f8 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -549,8 +549,8 @@ static int geni_i2c_probe(struct platform_device *pdev) init_completion(&gi2c->done); spin_lock_init(&gi2c->lock); platform_set_drvdata(pdev, gi2c); - ret = devm_request_irq(&pdev->dev, gi2c->irq, geni_i2c_irq, - IRQF_TRIGGER_HIGH, "i2c_geni", gi2c); + ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, 0, + dev_name(&pdev->dev), gi2c); if (ret) { dev_err(&pdev->dev, "Request_irq failed:%d: err:%d\n", gi2c->irq, ret); -- Sent by a computer, using git, on the internet