From: David Miller <davem@davemloft.net>
To: mdf@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-parisc@vger.kernel.org, mst@redhat.com,
hkallweit1@gmail.com, morats@google.com
Subject: Re: [PATCH] net: ethernet: dec: tulip: Fix length mask in receive length calculation
Date: Wed, 05 Feb 2020 14:21:58 +0100 (CET) [thread overview]
Message-ID: <20200205.142158.1877672466689439631.davem@davemloft.net> (raw)
In-Reply-To: <20200204230118.7877-1-mdf@kernel.org>
From: Moritz Fischer <mdf@kernel.org>
Date: Tue, 4 Feb 2020 15:01:18 -0800
> The receive frame length calculation uses a wrong mask to calculate the
> length of the received frames.
>
> Per spec table 4-1 the length is contained in the FL (Frame Length)
> field in bits 30:16.
>
> This didn't show up as an issue so far since frames were limited to
> 1500 bytes which falls within the 11 bit window.
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
Applied, thanks.
prev parent reply other threads:[~2020-02-05 13:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 23:01 Moritz Fischer
2020-02-05 13:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205.142158.1877672466689439631.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=morats@google.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®