From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B19DC352A2 for ; Wed, 5 Feb 2020 17:40:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D595217F4 for ; Wed, 5 Feb 2020 17:40:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727446AbgBERkk (ORCPT ); Wed, 5 Feb 2020 12:40:40 -0500 Received: from ms.lwn.net ([45.79.88.28]:52698 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727116AbgBERkk (ORCPT ); Wed, 5 Feb 2020 12:40:40 -0500 Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 016206E5; Wed, 5 Feb 2020 17:40:39 +0000 (UTC) Date: Wed, 5 Feb 2020 10:40:38 -0700 From: Jonathan Corbet To: Stephen Kitt Cc: Mauro Carvalho Chehab , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Allow git builds of Sphinx Message-ID: <20200205104038.7b27a94f@lwn.net> In-Reply-To: <20200124183316.1719218-1-steve@sk2.org> References: <20200124183316.1719218-1-steve@sk2.org> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Jan 2020 19:33:16 +0100 Stephen Kitt wrote: > When using a non-release version of Sphinx, from a local build (with > improvements for kernel doc handling, why not), > > sphinx-build --version > > reports versions of the form > > sphinx-build 3.0.0+/4703d9119972 > > i.e. base version, a plus symbol, slash, and the start of the git hash > of whatever repository the command is run in (no, not the hash that > was used to build Sphinx!). > > This patch fixes the installation check in sphinx-pre-install to > recognise such version output. > > Signed-off-by: Stephen Kitt > --- Seems useful. Applied, thanks. jon