From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,PDS_TONAME_EQ_TOLOCAL_SHORT,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1BC2C35254 for ; Wed, 5 Feb 2020 14:12:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D12121741 for ; Wed, 5 Feb 2020 14:12:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728261AbgBEOMA convert rfc822-to-8bit (ORCPT ); Wed, 5 Feb 2020 09:12:00 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:35602 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728057AbgBEOMA (ORCPT ); Wed, 5 Feb 2020 09:12:00 -0500 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1izLPH-0002qQ-Kj; Wed, 05 Feb 2020 15:11:55 +0100 Date: Wed, 5 Feb 2020 15:11:55 +0100 From: Sebastian Andrzej Siewior To: maddy Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Mark Rutland , Peter Zijlstra , Arnaldo Carvalho de Melo , Alexander Shishkin , Ingo Molnar , Paul Mackerras , Namhyung Kim , Thomas Gleixner , Jiri Olsa Subject: Re: [RFC] per-CPU usage in perf core-book3s Message-ID: <20200205141155.ssmlyt72xu7sieuh@linutronix.de> References: <20200127150620.taio2txyqreg4kn6@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-02-05 07:10:59 [+0530], maddy wrote: > Yes, currently we dont have anything that prevents the timer > callback to interrupt pmu::event_init. Nice catch. Thanks for > pointing this out. You are welcome. > Looking at the code, per-cpu variable access are made to > check for constraints and for Branch Stack (BHRB). So could > wrap this block of  pmu::event_init with local_irq_save/restore. > Will send a patch to fix it. Okay. Please keep me in the loop :) > > Maddy Sebastian