From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89567C2D0B1 for ; Thu, 6 Feb 2020 11:32:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5970021741 for ; Thu, 6 Feb 2020 11:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580988772; bh=SHuKuVXhQ2joYWvyaHuAjPTNnn5lin5358YGydP+5t4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QKw0fNLO9AMbPJJd1mh4he+bQbZz6DAC+SaaMmU33tCxbPUqeGPjyg/2RGEwxLaKq bekEh4X9X4fvGPH/vKCWjKJZelVBA2s0dol30g+VAQEolf2ZisY+DxiG5S/FG6u1YM ttX9GrnoGGlTByQUdoFIDu6qW4fPeLQSi8cjVzkU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727628AbgBFLcv (ORCPT ); Thu, 6 Feb 2020 06:32:51 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:59262 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726538AbgBFLcv (ORCPT ); Thu, 6 Feb 2020 06:32:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SHuKuVXhQ2joYWvyaHuAjPTNnn5lin5358YGydP+5t4=; b=HCiv7PZ6jf6iaBcHIyxy1mfmV +6+tnV0C35zAaFUozTlf+yJeb6rG70fq34x6eITuapmMknM+uCzDZdWo8zesCIgpaWouXfnmcVeIA Fh/adKLtITforr3O+cs+cDXT1hFvPCJ9+QdJCp5V5opTRIj0wLbzJo8uj/ieZt+fbd/1E=; Received: from fw-tnat-cam3.arm.com ([217.140.106.51] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1izfOq-0001V2-DG; Thu, 06 Feb 2020 11:32:48 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 28ECDD01D7F; Thu, 6 Feb 2020 11:32:48 +0000 (GMT) Date: Thu, 6 Feb 2020 11:32:48 +0000 From: Mark Brown To: Rishi Gupta Cc: support.opensource@diasemi.com, Adam.Thomson.Opensource@diasemi.com, axel.lin@ingics.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] regulator: da9063: remove redundant return statement Message-ID: <20200206113248.GL3897@sirena.org.uk> References: <1580963761-24964-1-git-send-email-gupt21@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BOHdEyqYAbgZNeC0" Content-Disposition: inline In-Reply-To: <1580963761-24964-1-git-send-email-gupt21@gmail.com> X-Cookie: Programming is an unnatural act. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --BOHdEyqYAbgZNeC0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 06, 2020 at 10:06:01AM +0530, Rishi Gupta wrote: > The devm_request_threaded_irq() already returns 0 on success > and negative error code on failure. So return from this itself > can be used while preserving error log in case of failure. >=20 > This commit also fixes checkpatch.pl errors & warnings: > - WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > - WARNING: line over 80 characters > - ERROR: space prohibited before that ',' (ctx:WxW) > - ERROR: code indent should use tabs where possible > - WARNING: Block comments use * on subsequent lines This should be split into separate patches, each doing one thing as covered in submitting-patchs.rst. --BOHdEyqYAbgZNeC0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl47+V8ACgkQJNaLcl1U h9BPKQf/fHvKdeAiBBwX2Gn0hIr6gFUSdbvE1pcAs5EUmIgpEl9xXPDDDoOSWb4s oZoqxoyCLUBFKnoIwqdVM3GtqLxhqw6fTj4NvgFZ0/NOTiqWefZiQvfH2AFCfv0h 1/eKbCikOVboXctMsS21zWyGWd9MM02ckWnX2rK/32HsNzsbsW9TPm+lvwg34DYG iIS/8w3tjHjE431ixpkBiZcrpSnM94x8c/WNZEO/K6B+gbgXbZK8zIZJbAjD95yL 2gdu2CwMEvoi4BhiZZ9wx0TSIRbTigPhffuaFOMonUadtnyfxuy4ADR2q7MxzQlU f4Uzbo8vvdsc7dTw8sWiPd77rOQBfQ== =WAMp -----END PGP SIGNATURE----- --BOHdEyqYAbgZNeC0--