From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1A10C352A2 for ; Fri, 7 Feb 2020 11:57:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0B4A20715 for ; Fri, 7 Feb 2020 11:57:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HuJlIK4m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727012AbgBGL5x (ORCPT ); Fri, 7 Feb 2020 06:57:53 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:42448 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726860AbgBGL5x (ORCPT ); Fri, 7 Feb 2020 06:57:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581076671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=l9Om1VdDqKQp4D0lip8cfLl2U7Dg5Wq0M3QVMJgD+1I=; b=HuJlIK4mI0T3HF3SW2RYsN3XVOwSgp+GZ55YRygbyeJRgGwBDejfKVsaoK1L/AZD6RmPlb BTZqD4yGUX4RASHwW2veREqTpuEMfEVNqPgUlz1XmiBn4a7ZcDV9vPTYkRSKNsqOn3M4Ri ZJfkpL2k/ujLd1TKx3XLVv7n4u1kPIY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-Wx585QMENKWhZ0HmxUjXYA-1; Fri, 07 Feb 2020 06:57:49 -0500 X-MC-Unique: Wx585QMENKWhZ0HmxUjXYA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 30061DBA3; Fri, 7 Feb 2020 11:57:48 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-112.ams2.redhat.com [10.36.116.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id 606D4790F2; Fri, 7 Feb 2020 11:57:45 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id A26201747D; Fri, 7 Feb 2020 12:57:44 +0100 (CET) From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org Cc: marmarek@invisiblethingslab.com, Gerd Hoffmann , David Airlie , Daniel Vetter , virtualization@lists.linux-foundation.org (open list:DRM DRIVER FOR BOCHS VIRTUAL GPU), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning Date: Fri, 7 Feb 2020 12:57:44 +0100 Message-Id: <20200207115744.4559-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Shutdown of firmware framebuffer has a bunch of problems. Because of this the framebuffer region might still be reserved even after drm_fb_helper_remove_conflicting_pci_framebuffers() returned. Don't consider pci_request_region() failure for the framebuffer region as fatal error to workaround this issue. Reported-by: Marek Marczykowski-G=C3=B3recki Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_hw.c b/drivers/gpu/drm/bochs/boc= hs_hw.c index b615b7dfdd9d..a387efa9e559 100644 --- a/drivers/gpu/drm/bochs/bochs_hw.c +++ b/drivers/gpu/drm/bochs/bochs_hw.c @@ -157,8 +157,7 @@ int bochs_hw_init(struct drm_device *dev) } =20 if (pci_request_region(pdev, 0, "bochs-drm") !=3D 0) { - DRM_ERROR("Cannot request framebuffer\n"); - return -EBUSY; + DRM_WARN("Cannot request framebuffer, boot framebuffer still active?\n= "); } =20 bochs->fb_map =3D ioremap(addr, size); --=20 2.18.1