From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7459FC3F68F for ; Sun, 9 Feb 2020 18:26:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DAF0207FF for ; Sun, 9 Feb 2020 18:26:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="wvHeUsjj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727874AbgBIS0U (ORCPT ); Sun, 9 Feb 2020 13:26:20 -0500 Received: from mail-40134.protonmail.ch ([185.70.40.134]:47019 "EHLO mail-40134.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727388AbgBIS0U (ORCPT ); Sun, 9 Feb 2020 13:26:20 -0500 Date: Sun, 09 Feb 2020 18:26:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1581272777; bh=MzjLn6J/wE/n8CGcKBz+chhgLW9dAzTv6jT3ub5OgLA=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References: Feedback-ID:From; b=wvHeUsjjEUksZA1m1G6v8UXWf6uVjQO8v+UIYIZQDNS0E8TCd8z9t/5zOi/Wkx0dZ ssnq2h3j9ayehc7Xi6mJWVY9SmojAdLNvGze+secgokXOur88FUFrvsyMGY1GHgsv6 AY7bhyvItVBqjlNQijPvwILTA5RXn9JH81fDk8N4= To: Ezequiel Garcia From: =?UTF-8?Q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Cc: linux-media , Helen Koike , Shuah Khan , Mauro Carvalho Chehab , Hans Verkuil , Linux Kernel Mailing List , lkcamp@lists.libreplanetbr.org Reply-To: =?UTF-8?Q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Subject: Re: [PATCH 0/3] media: vimc: Add support for GBR and BGR formats on source pad of debayer Message-ID: <20200209182556.dkey2zlqg3u2a4um@ArchWay.local> In-Reply-To: References: <20200202155019.1029993-1-nfraprado@protonmail.com> Feedback-ID: cwTKJQq-dqva77NrgNeIaWzOvcDQqfI9VSy7DoyJdvgY6-nEE7fD-E-3GiKFHexW4OBWbzutmMZN6q4SflMDRw==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Ezequiel. On Sun, Feb 09, 2020 at 02:09:17PM -0300, Ezequiel Garcia wrote: >=20 > On Sun, 2 Feb 2020 at 12:50, N=C3=ADcolas F. R. A. Prado > wrote: > > > > The objective of this series is to add support for GBR and BGR media bu= s formats > > for the source pad of debayer subdevices of the vimc driver. > > >=20 > Can you elaborate why is this needed, e.g. what use-case is this enabling= , > or what is this fixing? Sure. At the moment, the only supported media bus format on the source pad of the debayer subdevice is the RGB888_1X24. The mbus format of the source pad of the debayer ultimately determines the pixelformat that is streamed on /dev/video3, since: * The mbus formats of the links on the topology have to match for the streaming to be possible, and [1] shows that the source pad of the debayer links to the sink of the scaler. * The scaler uses the same mbus format on sink and source. * The source pad of the scaler is linked to the /dev/video3 Capture. That said, there isn't a GBR pixelformat, so it uses the RGB pixelformat. So what this patch series enables: * Setting debayer and scaler subdevices to use GBR and BGR mbus formats= . * Stream video using the BGR pixelformat from /dev/video3. By enabling these, it makes it possible to use vimc to emulate hardware tha= t uses GBR or BGR mbus formats internally or that streams using the BGR pixelformat. Regards, N=C3=ADcolas [1] https://linuxtv.org/downloads/v4l-dvb-apis-new/v4l-drivers/vimc.html#to= pology >=20 > Thanks, > Ezequiel