From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] printk: Move console matching logic into a separate function
Date: Thu, 13 Feb 2020 14:42:37 +0900 [thread overview]
Message-ID: <20200213054237.GD13208@google.com> (raw)
In-Reply-To: <e6b63bc26108c6e3645f9ea9e03aba38fd8b8464.camel@kernel.crashing.org>
On (20/02/06 15:02), Benjamin Herrenschmidt wrote:
[..]
> +
> + /*
> + * Some consoles, such as pstore and netconsole, can be enabled even
> + * without matching.
> + */
> + if (newcon->flags & CON_ENABLED)
> + return 0;
> +
> + return -ENOENT;
> +}
Looks good to me // modulo checkpatch warnings //
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
prev parent reply other threads:[~2020-02-13 5:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 4:02 Benjamin Herrenschmidt
2020-02-11 14:29 ` Petr Mladek
2020-02-11 15:26 ` Benjamin Herrenschmidt
2020-02-13 5:42 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213054237.GD13208@google.com \
--to=sergey.senozhatsky.work@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome