From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6426AC2BA83 for ; Fri, 14 Feb 2020 14:16:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37D88206B6 for ; Fri, 14 Feb 2020 14:16:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581689810; bh=5HALsHiDTL4axGdxa3WIcXS5r2rp1q38KCHpbT5M5g8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Ac9JBtkeM6UVxeZo/VpCAV3OiURyXoSbD0ZdcwnSIEgAftngbkFljiN5j5NR2dnjz F9MRhhdWeuwerh9h616g7WD1HzhtZbvWmkSaeBtiu0nrFaQTfwe78ROgE5wLqEmQgh Bnj9Pev05TzXI2Yn3IQlwPB++ybmOsVnWD7sH7yM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729424AbgBNOQt (ORCPT ); Fri, 14 Feb 2020 09:16:49 -0500 Received: from foss.arm.com ([217.140.110.172]:33560 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbgBNOQs (ORCPT ); Fri, 14 Feb 2020 09:16:48 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A4E141FB; Fri, 14 Feb 2020 06:16:47 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 283DB3F68F; Fri, 14 Feb 2020 06:16:47 -0800 (PST) Date: Fri, 14 Feb 2020 14:16:45 +0000 From: Mark Brown To: Simon Goldschmidt Cc: "Ramuthevar,Vadivel MuruganX" , linux-kernel , linux-spi@vger.kernel.org, Vignesh R , Mark Rutland , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , dan.carpenter@oracle.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com Subject: Re: [PATCH v9 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Message-ID: <20200214141645.GM4827@sirena.org.uk> References: <20200214114618.29704-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200214121145.GF4827@sirena.org.uk> <20200214131518.GJ4827@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rf72Gf+bfLC8kxKs" Content-Disposition: inline In-Reply-To: X-Cookie: Shipping not included. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --rf72Gf+bfLC8kxKs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 14, 2020 at 02:49:48PM +0100, Simon Goldschmidt wrote: > On Fri, Feb 14, 2020 at 2:15 PM Mark Brown wrote: > > I'm not seeing anything in the driver that removes whatever the current > > support is? Unless it's just adding a duplicate driver for the same > > compatible strings which is obviously a bad idea but at least means that > > unless people enable the driver there's no risk of it colliding with the > > existing one. > It does add a duplicate driver for the same compatible strings. The current > working driver is in 'drivers/mtd/spi-nor/cadence-quadspi.c'. > In fact, the compatible string "cdns,qspi-nor" copied from the old driver to > this new driver is *only* used for altera. TI has its own compatible string, > the new Intel platform adds its own as well. Oh, that's not good - it's adding a completely new binding for the same compatibles which isn't OK. We can transition to a new driver using the same binding but we should be keeping the old binding. If we're moving the binding document around and/or transitioning to YAML that needs to be done explicitly rather than adding a new document for the same compatible. > As long as that one doesn't get removed, I have nothing against this driver > here. I'm only concerned that this will get forgotten. And given that I added > altera guys to the loop in one of the previous versions, I just was surprised > they aren't on CC in this version. Yes, like I say it'd be much better to get their review. --rf72Gf+bfLC8kxKs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5Gq8wACgkQJNaLcl1U h9DHoQf+LsSB3ZHCDD01+GU4dangDKO0Y7qLxBcScMbJ4+Xuws5182R7ns4mhTmt wTsTbbf+Y3qfIXqReAzBxs5lRRxl46CdLexDJe/CRPKr+ADYByxAOhYcQ8jtPZzd 9QNw3ftS8JICO81XdPsIH9FdPHbMfj1/H+Js5GhfppYUbsvvrxUI1njQ06mF6sOw oCymlCc+ruUgLSR0fA4FsBrLFmWMJTor8kudFBLupMeJs9F3dB2jgmQbkHmlfm1z X/fJnZRpD7voBp4x2TFfm+lx/m6OBPTLuOCuu6CON9p3ahH4KoSB1YXLl8S/d1Ew YV2Vi7U/k2epOpGy2yjWnN2je8whYA== =ysJH -----END PGP SIGNATURE----- --rf72Gf+bfLC8kxKs--