From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB336C2BA83 for ; Fri, 14 Feb 2020 16:13:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB0B1246B9 for ; Fri, 14 Feb 2020 16:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581696785; bh=FTOGElWgnVJw8gJktUCYPCksvhO+Fz5drW+cZvE/jw0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Q20aYa/vG0DoapYEwLMSIwnCu1cyM+j+OFhtmMosvTYEE3V/66S/sjsastsRWvcJY s2g/QYbNYawnwGZVH0DaN4yCXqSjUFwIEmILjE7UKGb46MPrQB9eXr3iP0YGKGSUf1 z4DQnUvhzn3cXiiwXE+qPA7bqx2M7mznRcHwBi70= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392105AbgBNQNF (ORCPT ); Fri, 14 Feb 2020 11:13:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:39524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391936AbgBNQMN (ORCPT ); Fri, 14 Feb 2020 11:12:13 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5DDBF246A6; Fri, 14 Feb 2020 16:12:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581696733; bh=FTOGElWgnVJw8gJktUCYPCksvhO+Fz5drW+cZvE/jw0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dLJ1+4Rl7X99NVKmsz4XbJYKkjrj+MkGgfHb2nwjmUTzmdCdUwGHGQZXjdZkwP8YY feWleC+GW5bLZBcqT7ggY5vwDaqbJstQNsw9yQaap++uChAavGcsZugQDgs4sdWKWw hHSH0NWti7zYyO92s0MqzcDC4ORt5pcSaXHIrrGw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jacob Pan , Eric Auger , Lu Baolu , Joerg Roedel , Sasha Levin , iommu@lists.linux-foundation.org Subject: [PATCH AUTOSEL 4.19 019/252] iommu/vt-d: Fix off-by-one in PASID allocation Date: Fri, 14 Feb 2020 11:07:54 -0500 Message-Id: <20200214161147.15842-19-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200214161147.15842-1-sashal@kernel.org> References: <20200214161147.15842-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jacob Pan [ Upstream commit 39d630e332144028f56abba83d94291978e72df1 ] PASID allocator uses IDR which is exclusive for the end of the allocation range. There is no need to decrement pasid_max. Fixes: af39507305fb ("iommu/vt-d: Apply global PASID in SVA") Reported-by: Eric Auger Signed-off-by: Jacob Pan Reviewed-by: Eric Auger Signed-off-by: Lu Baolu Signed-off-by: Joerg Roedel Signed-off-by: Sasha Levin --- drivers/iommu/intel-svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c index fd8730b2cd46e..5944d3b4dca37 100644 --- a/drivers/iommu/intel-svm.c +++ b/drivers/iommu/intel-svm.c @@ -377,7 +377,7 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_ /* Do not use PASID 0 in caching mode (virtualised IOMMU) */ ret = intel_pasid_alloc_id(svm, !!cap_caching_mode(iommu->cap), - pasid_max - 1, GFP_KERNEL); + pasid_max, GFP_KERNEL); if (ret < 0) { kfree(svm); kfree(sdev); -- 2.20.1