From: Steve Longerbeam <slongerbeam@gmail.com>
To: linux-media@vger.kernel.org
Cc: Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org (open list)
Subject: [RESEND PATCH v3 07/17] media: video-mux: Create media links in bound notifier
Date: Sat, 15 Feb 2020 11:41:26 -0800 [thread overview]
Message-ID: <20200215194136.10131-8-slongerbeam@gmail.com> (raw)
In-Reply-To: <20200215194136.10131-1-slongerbeam@gmail.com>
Implement a notifier bound op to register media links from the remote
sub-device's source pad(s) to the video-mux sink pad(s).
Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
---
Changes in v3:
- this version does the work inline. The previous version called
a media_create_fwnode_links() which is removed in v3.
---
drivers/media/platform/video-mux.c | 92 ++++++++++++++++++++++++++++++
1 file changed, 92 insertions(+)
diff --git a/drivers/media/platform/video-mux.c b/drivers/media/platform/video-mux.c
index c1c477e4e33f..a6b09a79fbe3 100644
--- a/drivers/media/platform/video-mux.c
+++ b/drivers/media/platform/video-mux.c
@@ -36,6 +36,12 @@ static const struct v4l2_mbus_framefmt video_mux_format_mbus_default = {
.field = V4L2_FIELD_NONE,
};
+static inline struct video_mux *
+notifier_to_video_mux(struct v4l2_async_notifier *n)
+{
+ return container_of(n, struct video_mux, notifier);
+}
+
static inline struct video_mux *v4l2_subdev_to_video_mux(struct v4l2_subdev *sd)
{
return container_of(sd, struct video_mux, subdev);
@@ -372,6 +378,90 @@ static int video_mux_parse_endpoint(struct device *dev,
return fwnode_device_is_available(asd->match.fwnode) ? 0 : -ENOTCONN;
}
+static int video_mux_notify_bound(struct v4l2_async_notifier *notifier,
+ struct v4l2_subdev *sd,
+ struct v4l2_async_subdev *asd)
+{
+ struct video_mux *vmux = notifier_to_video_mux(notifier);
+ struct fwnode_handle *vmux_fwnode = dev_fwnode(vmux->subdev.dev);
+ struct fwnode_handle *sd_fwnode = dev_fwnode(sd->dev);
+ struct fwnode_handle *vmux_ep;
+
+ fwnode_graph_for_each_endpoint(vmux_fwnode, vmux_ep) {
+ struct fwnode_handle *remote_ep, *sd_ep;
+ struct media_pad *src_pad, *sink_pad;
+ struct fwnode_endpoint fwep;
+ int src_idx, sink_idx, ret;
+ bool remote_ep_belongs;
+
+ ret = fwnode_graph_parse_endpoint(vmux_ep, &fwep);
+ if (ret)
+ continue;
+
+ /* only create links to the vmux sink pads */
+ if (fwep.port >= vmux->subdev.entity.num_pads - 1)
+ continue;
+
+ sink_idx = fwep.port;
+ sink_pad = &vmux->subdev.entity.pads[sink_idx];
+
+ remote_ep = fwnode_graph_get_remote_endpoint(vmux_ep);
+ if (!remote_ep)
+ continue;
+
+ /*
+ * verify that this remote endpoint is owned by the
+ * sd, in case the sd does not check for that in its
+ * .get_fwnode_pad operation or does not implement it.
+ */
+ remote_ep_belongs = false;
+ fwnode_graph_for_each_endpoint(sd_fwnode, sd_ep) {
+ if (sd_ep == remote_ep) {
+ remote_ep_belongs = true;
+ fwnode_handle_put(sd_ep);
+ break;
+ }
+ }
+ if (!remote_ep_belongs)
+ continue;
+
+ src_idx = media_entity_get_fwnode_pad(&sd->entity, remote_ep,
+ MEDIA_PAD_FL_SOURCE);
+ fwnode_handle_put(remote_ep);
+
+ if (src_idx < 0)
+ continue;
+
+ src_pad = &sd->entity.pads[src_idx];
+
+ /* skip this link if it already exists */
+ if (media_entity_find_link(src_pad, sink_pad))
+ continue;
+
+ ret = media_create_pad_link(&sd->entity, src_idx,
+ &vmux->subdev.entity,
+ sink_idx, 0);
+ if (ret) {
+ dev_err(vmux->subdev.dev,
+ "%s:%d -> %s:%d failed with %d\n",
+ sd->entity.name, src_idx,
+ vmux->subdev.entity.name, sink_idx, ret);
+ fwnode_handle_put(vmux_ep);
+ return ret;
+ }
+
+ dev_dbg(vmux->subdev.dev, "%s:%d -> %s:%d\n",
+ sd->entity.name, src_idx,
+ vmux->subdev.entity.name, sink_idx);
+ }
+
+ return 0;
+}
+
+static const struct v4l2_async_notifier_operations video_mux_notify_ops = {
+ .bound = video_mux_notify_bound,
+};
+
static int video_mux_async_register(struct video_mux *vmux,
unsigned int num_input_pads)
{
@@ -386,6 +476,8 @@ static int video_mux_async_register(struct video_mux *vmux,
v4l2_async_notifier_init(&vmux->notifier);
+ vmux->notifier.ops = &video_mux_notify_ops;
+
ret = v4l2_async_register_fwnode_subdev(
&vmux->subdev, &vmux->notifier,
sizeof(struct v4l2_async_subdev),
--
2.17.1
next prev parent reply other threads:[~2020-02-15 19:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200215194136.10131-1-slongerbeam@gmail.com>
2020-02-15 19:41 ` [RESEND PATCH v3 01/17] media: entity: Pass entity to get_fwnode_pad operation Steve Longerbeam
2020-02-15 19:41 ` [RESEND PATCH v3 02/17] media: v4l2-fwnode: Pass notifier to v4l2_async_register_fwnode_subdev() Steve Longerbeam
2020-02-25 15:07 ` Sakari Ailus
2020-02-26 23:50 ` Steve Longerbeam
2020-02-27 7:50 ` Sakari Ailus
2020-02-28 18:16 ` Steve Longerbeam
2020-02-28 22:27 ` Sakari Ailus
2020-02-15 19:41 ` [RESEND PATCH v3 03/17] media: imx: csi: Implement get_fwnode_pad op Steve Longerbeam
2020-02-15 19:41 ` [RESEND PATCH v3 04/17] media: imx: mipi csi-2: " Steve Longerbeam
2020-02-15 19:41 ` [RESEND PATCH v3 05/17] media: video-mux: " Steve Longerbeam
2020-02-15 19:41 ` [RESEND PATCH v3 06/17] media: imx: Add imx_media_create_fwnode_pad_link() Steve Longerbeam
2020-02-15 19:41 ` Steve Longerbeam [this message]
2020-02-15 19:41 ` [RESEND PATCH v3 08/17] media: imx: mipi csi-2: Create media links in bound notifier Steve Longerbeam
2020-02-15 19:41 ` [RESEND PATCH v3 09/17] media: imx7-mipi-csis: " Steve Longerbeam
2020-02-15 19:41 ` [RESEND PATCH v3 10/17] media: imx7-media-csi: " Steve Longerbeam
2020-02-15 19:41 ` [RESEND PATCH v3 11/17] media: imx: csi: Embed notifier in struct csi_priv Steve Longerbeam
2020-02-15 19:41 ` [RESEND PATCH v3 12/17] media: imx: csi: Add missing notifier unregister/cleanup Steve Longerbeam
2020-02-15 19:41 ` [RESEND PATCH v3 13/17] media: imx: csi: Create media links in bound notifier Steve Longerbeam
2020-02-15 19:41 ` [RESEND PATCH v3 14/17] media: imx: csi: Lookup upstream endpoint with imx_media_get_pad_fwnode Steve Longerbeam
2020-02-15 19:41 ` [RESEND PATCH v3 15/17] media: imx: Create missing links from CSI-2 receiver Steve Longerbeam
2020-02-15 19:41 ` [RESEND PATCH v3 16/17] media: imx: silence a couple debug messages Steve Longerbeam
2020-02-15 19:41 ` [RESEND PATCH v3 17/17] media: imx: TODO: Remove media link creation todos Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200215194136.10131-8-slongerbeam@gmail.com \
--to=slongerbeam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome