From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E4CC7619D for ; Mon, 17 Feb 2020 03:23:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E33E2072C for ; Mon, 17 Feb 2020 03:23:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727883AbgBQDXq (ORCPT ); Sun, 16 Feb 2020 22:23:46 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:48222 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727755AbgBQDXo (ORCPT ); Sun, 16 Feb 2020 22:23:44 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E3A61155CAC60; Sun, 16 Feb 2020 19:23:43 -0800 (PST) Date: Sun, 16 Feb 2020 19:23:43 -0800 (PST) Message-Id: <20200216.192343.2089015531155068961.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, olteanv@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: dsa: b53: Ensure the default VID is untagged From: David Miller In-Reply-To: <20200214232619.26482-1-f.fainelli@gmail.com> References: <20200214232619.26482-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 16 Feb 2020 19:23:44 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Fri, 14 Feb 2020 15:26:19 -0800 > We need to ensure that the default VID is untagged otherwise the switch > will be sending tagged frames and the results can be problematic. This > is especially true with b53 switches that use VID 0 as their default > VLAN since VID 0 has a special meaning. > > Fixes: fea83353177a ("net: dsa: b53: Fix default VLAN ID") > Fixes: 061f6a505ac3 ("net: dsa: Add ndo_vlan_rx_{add, kill}_vid implementation") > Signed-off-by: Florian Fainelli Applied, thanks Florian.