From: sunnypranay <mpranay2017@gmail.com>
To: abbotti@mev.co.uk
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
sunnypranay <mpranay2017@gmail.com>
Subject: [PATCH] Staging: comedi: drivers: fixed errors warning coding style issue
Date: Sun, 16 Feb 2020 13:45:18 +0530 [thread overview]
Message-ID: <20200216081518.3516-1-mpranay2017@gmail.com> (raw)
Fixed a coding style issue.
Signed-off-by: sunnypranay <mpranay2017@gmail.com>
---
drivers/staging/comedi/drivers.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index 750a6ff3c03c..76395de100a6 100644
--- a/drivers/staging/comedi/drivers.c
+++ b/drivers/staging/comedi/drivers.c
@@ -133,7 +133,7 @@ EXPORT_SYMBOL_GPL(comedi_alloc_subdevices);
* On success, @s->readback points to the first element of the array, which
* is zero-filled. The low-level driver is responsible for updating its
* contents. @s->insn_read will be set to comedi_readback_insn_read()
- * unless it is already non-NULL.
+ * Unless it is already non-NULL.
*
* Returns 0 on success, -EINVAL if the subdevice has no channels, or
* -ENOMEM on allocation failure.
@@ -282,8 +282,20 @@ EXPORT_SYMBOL_GPL(comedi_readback_insn_read);
* continue waiting or some other value to stop waiting (generally 0 if the
* condition occurred, or some error value).
*
- * Returns -ETIMEDOUT if timed out, otherwise the return value from the
- * callback function.
+ * Redback_insn_read() - A generic (*insn_read) for subdevice readback.
+ * @dev: COMEDI device.
+ * @s: COMEDI subdevice.
+ * @insn: COMEDI instruction.
+ * @data: Pointer to return the readback data.
+ * Handles the %INSN_READ instruction for subdevices that use the readback
+ * array allocated by comedi_alloc_subdev_readback(). It may be used
+ * directly as the subdevice's handler (@s->insn_read) or called via a
+ * wrapper.
+ * @insn->n is normally 1, which will read a single value. If higher, the
+ * same element of the readback array will be read multiple times.
+ * Returns @insn->n on success,
+ * or -EINVAL if @s->readback is NULL.turns -ETIMEDOUT if timed out,
+ * otherwise the return value from the callback function.
*/
int comedi_timeout(struct comedi_device *dev,
struct comedi_subdevice *s,
--
2.17.1
next reply other threads:[~2020-02-16 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 8:15 sunnypranay [this message]
2020-02-16 12:21 ` Greg KH
[not found] ` <CAD=0X6XpJ0yfodr6YzexbKZm_n0GgKE=heNhXZrBDoEt-8u53A@mail.gmail.com>
2020-02-17 16:01 ` Greg KH
2020-02-18 8:04 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200216081518.3516-1-mpranay2017@gmail.com \
--to=mpranay2017@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome