From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18999C34024 for ; Mon, 17 Feb 2020 14:23:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4C432072C for ; Mon, 17 Feb 2020 14:23:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Rzzz/Sfn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728493AbgBQOX2 (ORCPT ); Mon, 17 Feb 2020 09:23:28 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:50885 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728044AbgBQOX2 (ORCPT ); Mon, 17 Feb 2020 09:23:28 -0500 Received: by mail-wm1-f65.google.com with SMTP id a5so17315479wmb.0 for ; Mon, 17 Feb 2020 06:23:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Y5MhYckXFi7E+U6LXNEiPSCxK67PLr+e99TA6/7sYAM=; b=Rzzz/Sfn1uQgXNWGQGaIWsEyP8+93DXjBoaUqHAsAnl21gystvq7FmsEebbPlmneJ4 WPpaP8SSyqOfo8BKWzKhuiwyX1blJBmAEu3vlehSLUie8H2poU0YdqYVxJdrVIL3eSjN yhclUTKN4cIiRjj6T+DTlTeV2x/r/yWx8v+S49mHT3saeSUZ0CS8pWMjgcrStEQCMZ6k Cff6lwFkleSd8Wh2IesQnt5iaW9B/um4liCPAXtW4r5XPyXtrWmYCxWM0TPwKvhpqiBG WSkGO5scwqCPmq3XG+lpG1Tc23A+Q4KMBm28ms7SJdd0Bmhr2PBg5ItoCbN0OKxhUHhC v3pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Y5MhYckXFi7E+U6LXNEiPSCxK67PLr+e99TA6/7sYAM=; b=AxqmPy28i7IN2EhJCHf6WIKjTFXbyDHMvkJCyJDoVJtN88JkCtDfuboBWFScfIJByX 1ufIJ7g+UpryaQvURQlXEzkN+a+VIAoK2Z2/OJIvs495ezwwpIem/LzQxUZbv6FjPO+W hin1FJL0pmoRdxdEFfaplI4Mr6dupy+0pg/lRwrrUiP1Ejztv4GSDxqWpoIZcPgsMMcr sroSs2FG5ZAphrIpo6lXDNPek0qzYFg/VyZvDYZuXsHzjWvqltS6IbA4jIQQ26Ugrw/E dMfum0orv9BsTEDsspDAsKgMhYxXglPdxzTUHtBeeOBHPMWQZobv9nuMQZNnxwRU02Gu VTXA== X-Gm-Message-State: APjAAAXShK5UYdxly8mOGCQbBthJR5rjNlZTo+ZjxY9zmNJggDRZioLF vkldHI250/nsXsN6JCm9tBljkQ== X-Google-Smtp-Source: APXvYqxtx8O8cc/7sFx4a3FPrPBFBkfOU2HN+J+iaVebQNuJy0JLt7+fy9XZJ4eSs8byroNULYIKWw== X-Received: by 2002:a1c:4008:: with SMTP id n8mr22528670wma.121.1581949406315; Mon, 17 Feb 2020 06:23:26 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id q9sm1147425wrx.18.2020.02.17.06.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 06:23:25 -0800 (PST) Date: Mon, 17 Feb 2020 14:23:22 +0000 From: Quentin Perret To: masahiroy@kernel.org, nico@fluxnic.net Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, maennich@google.com, kernel-team@android.com, jeyu@kernel.org, hch@infradead.org Subject: Re: [PATCH v4 1/3] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYMS Message-ID: <20200217142322.GA183353@google.com> References: <20200212202140.138092-1-qperret@google.com> <20200212202140.138092-2-qperret@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212202140.138092-2-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 12 Feb 2020 at 20:21:38 (+0000), Quentin Perret wrote: > diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh > index a904bf1f5e67..93f4d10e66e6 100755 > --- a/scripts/adjust_autoksyms.sh > +++ b/scripts/adjust_autoksyms.sh > @@ -38,6 +38,10 @@ esac > # We need access to CONFIG_ symbols > . include/config/auto.conf > > +# Use 'eval' to expand the whitelist path and check if it is relative > +eval ksym_wl="${CONFIG_UNUSED_KSYMS_WHITELIST:-/dev/null}" > +[ "${ksym_wl:0:1}" = "/" ] || ksym_wl="$abs_srctree/$ksym_wl" Our internal CI just informed me that this is *still* not quite POSIX compliant ... I believe that the following should (finally) solve this issue: [ "${ksym_wl}" != "${ksym_wl#/}" ] || ksym_wl="$abs_srctree/$ksym_wl" The above seems to work with bash, zsh, dash, posh and, IIUC, complies with https://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html. I'll try other shells and stare at the doc some more, but if there is a preferred pattern in the kernel I'm happy to change it. Thanks, Quentin