From: Mark Brown <broonie@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ASoC: tlv320adcx140: Add the tlv320adcx140 codec driver family
Date: Tue, 18 Feb 2020 19:47:18 +0000 [thread overview]
Message-ID: <20200218194718.GO4232@sirena.org.uk> (raw)
In-Reply-To: <0faf0bfe-6186-59d0-e800-8523a33044dc@ti.com>
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
On Tue, Feb 18, 2020 at 01:32:05PM -0600, Dan Murphy wrote:
> On 2/18/20 1:23 PM, Mark Brown wrote:
> > On Tue, Feb 18, 2020 at 11:21:40AM -0600, Dan Murphy wrote:
> > > + if (unlikely(!tx_mask)) {
> > > + dev_err(component->dev, "tx and rx masks need to be non 0\n");
> > > + return -EINVAL;
> > > + }
> > Do you really need the unlikely() annotation here? This is *hopefully*
> > not a hot path.
> I was copying the code from tlv320aic3x.c as suggested by one our audio guys
> here in TI.
> I can remove it if you desire
It'd be better, they don't really help anything outside of fast paths.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-02-18 19:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 17:21 [PATCH v2 0/2] INtroduce the TLV320ADCx140 codec family Dan Murphy
2020-02-18 17:21 ` [PATCH v2 1/2] dt-bindings: sound: Add TLV320ADCx140 dt bindings Dan Murphy
2020-02-18 17:21 ` [PATCH v2 2/2] ASoC: tlv320adcx140: Add the tlv320adcx140 codec driver family Dan Murphy
2020-02-18 17:24 ` Dan Murphy
2020-02-18 19:23 ` Mark Brown
2020-02-18 19:32 ` Dan Murphy
2020-02-18 19:47 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218194718.GO4232@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dmurphy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome