From: Nathan Chancellor <natechancellor@gmail.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH 2/2] objtool: Improve call destination function detection
Date: Tue, 18 Feb 2020 12:58:38 -0700 [thread overview]
Message-ID: <20200218195838.GA8061@ubuntu-m2-xlarge-x86> (raw)
In-Reply-To: <0a7ee320bc0ea4469bd3dc450a7b4725669e0ea9.1581997059.git.jpoimboe@redhat.com>
On Mon, Feb 17, 2020 at 09:41:54PM -0600, Josh Poimboeuf wrote:
> A recent clang change, combined with a binutils bug, can trigger a
> situation where a ".Lprintk$local" STT_NOTYPE symbol gets created at the
> same offset as the "printk" STT_FUNC symbol. This confuses objtool:
>
> kernel/printk/printk.o: warning: objtool: ignore_loglevel_setup()+0x10: can't find call dest symbol at .text+0xc67
>
> Improve the call destination detection by looking specifically for an
> STT_FUNC symbol.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/872
> Link: https://sourceware.org/bugzilla/show_bug.cgi?id=25551
> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Tested with clang-11 and binutils 2.34, a combo that was previously
broken and I no longer see these warnings on either defconfig or
allyesconfig.
Tested-by: Nathan Chancellor <natechancellor@gmail.com>
next prev parent reply other threads:[~2020-02-18 20:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 3:41 [PATCH 0/2] objtool: clang-related fixes Josh Poimboeuf
2020-02-18 3:41 ` [PATCH 1/2] objtool: Fix clang switch table edge case Josh Poimboeuf
2020-02-18 19:57 ` Nathan Chancellor
2020-02-21 9:50 ` [tip: core/objtool] " tip-bot2 for Josh Poimboeuf
2020-02-18 3:41 ` [PATCH 2/2] objtool: Improve call destination function detection Josh Poimboeuf
2020-02-18 18:13 ` Nick Desaulniers
2020-02-18 19:58 ` Nathan Chancellor [this message]
2020-02-21 9:50 ` [tip: core/objtool] " tip-bot2 for Josh Poimboeuf
2020-02-20 19:06 ` [PATCH 0/2] objtool: clang-related fixes Nick Desaulniers
2020-02-20 19:27 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218195838.GA8061@ubuntu-m2-xlarge-x86 \
--to=natechancellor@gmail.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®