From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B902C34031 for ; Wed, 19 Feb 2020 02:51:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F10CF24655 for ; Wed, 19 Feb 2020 02:51:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582080717; bh=/yXdGWmYsKqPX70bTTNAr64nklyYO6iG2lgGEie9/Nc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gaSeIzmEVQmnfvIPN1YgKqXhJ1nF1yRAg7QYwbGdUTW5U8JqWGogGsKatJhD280UK haBgm8BE0zPrPP/SqWvNJjmVGr3GTubZKCBUy8C6HWLhSnpNYKyfSJCqXtZ2cVDS91 CwLaKsiSxkf+YQj3FE3CA8EicIzSj4B8IK0cYX/o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728276AbgBSCvz (ORCPT ); Tue, 18 Feb 2020 21:51:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:34168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728027AbgBSCvz (ORCPT ); Tue, 18 Feb 2020 21:51:55 -0500 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B4967207FD; Wed, 19 Feb 2020 02:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582080714; bh=/yXdGWmYsKqPX70bTTNAr64nklyYO6iG2lgGEie9/Nc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XR9V1FR5JQ/VnRmYbFVz1VJC0jUNv0LCv0L90Zs0t1FInM2sK6BPB89oh2nVAnsjz 1j8gWFCFmU3WBZ3o9K+XChjUjepAn00v8laLChhyc8WbUiZBkikuMGO+kbtxc8yiWM DcYckPYwAfceieD0lL4raxeXnD9eOSbbAd3roLCk= Date: Tue, 18 Feb 2020 18:51:54 -0800 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, chao@kernel.org Subject: Re: [PATCH 3/3] f2fs: avoid unneeded barrier in do_checkpoint() Message-ID: <20200219025154.GB96609@google.com> References: <20200218102136.32150-1-yuchao0@huawei.com> <20200218102136.32150-3-yuchao0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200218102136.32150-3-yuchao0@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/18, Chao Yu wrote: > We don't need to wait all dirty page submitting IO twice, > remove unneeded wait step. What happens if checkpoint and other meta writs are reordered? > > Signed-off-by: Chao Yu > --- > fs/f2fs/checkpoint.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index 751815cb4c2b..9c88fb3d255a 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -1384,8 +1384,6 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) > > /* Flush all the NAT/SIT pages */ > f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_CP_META_IO); > - /* Wait for all dirty meta pages to be submitted for IO */ > - f2fs_wait_on_all_pages(sbi, F2FS_DIRTY_META); > > /* > * modify checkpoint > -- > 2.18.0.rc1