From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1645C3404D for ; Wed, 19 Feb 2020 09:47:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B67F2464E for ; Wed, 19 Feb 2020 09:47:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="RoGEQR6+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726667AbgBSJrH (ORCPT ); Wed, 19 Feb 2020 04:47:07 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:33141 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726469AbgBSJrG (ORCPT ); Wed, 19 Feb 2020 04:47:06 -0500 Received: by mail-wr1-f67.google.com with SMTP id u6so27459260wrt.0 for ; Wed, 19 Feb 2020 01:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZSaOE1Qu/PM45Zep27V+i+rAGmMBianqxHPUxijGniA=; b=RoGEQR6+uEBeEhZkN+YFjpt4d7LT6G0ht2pkOT2ruGlhJI+dbNRYMwBlFGHQ1YUzIs +viyQVEKmxvuXb8EbXWEmstpROHR/KznqnVK9El5RKd8sIcfMP9Jhpq5mG+cVSig80WM y3NTwylBFmXRdWl9oSFmfpg60/n8LBwfcuG3hgNSohre8WBIscoFX+YJcROQ5qr98Snr kW1EHZGljfVf+OrgXOK7c83BZSw1CZKDKdCuxYj9lTIHkH4fCqdI187fPDoHaFE7A/JQ yRVgIJJZceLiqbS57laRbM/plKasZUaD/utPVUstGzjriP/5SMTg1EA4l6x/O6Wu+hjD qK2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZSaOE1Qu/PM45Zep27V+i+rAGmMBianqxHPUxijGniA=; b=KcT9VF9cwas09sa7PPPwyJmv6RUESYqzlQ+yn765eVAsxdP9fJHLBtWMWAuet/GElf 1D4tWRBJxL6Cw3PTaxThJzNse9SmEQMhYSoyrx9VvVVyzG9aPP0HCutrOOf+SHtL0H9k NAzeK0vaR8Ypv6Ur6JPIXt/DvSYz8b+Au8EquBGZ9VlHMbo7u/Sw/F1ObeFw5j5O6lxy rqevknX0ozsVdwbdOv4xg+XwgMkYOJodZYiCY/5hcbM+MECtmYXuHR7s7e6gQAiB016X jIdInr/77ipEAaSrN9BTbqlvompeeoKIDj/ZaVEtGP3XE9ABYqztR9j9ATl3joHAneD3 FFpg== X-Gm-Message-State: APjAAAU2CDyoh6pNimtL1eaCN5/pf2KoLFhWCoJ3mC858pPjehX2Ed64 X5YMKRo7H83AET7keRrtcR2FR1Qll9A= X-Google-Smtp-Source: APXvYqxE8JIxqFn+JsIZXr2z1XTvUwEMzRNPle7Eb2m5gt9NpGFBroR3+Wsds7aTN91RKZGXNlgutQ== X-Received: by 2002:adf:ff8c:: with SMTP id j12mr23976923wrr.354.1582105624478; Wed, 19 Feb 2020 01:47:04 -0800 (PST) Received: from localhost.localdomain (lfbn-nic-1-65-232.w2-15.abo.wanadoo.fr. [2.15.156.232]) by smtp.gmail.com with ESMTPSA id s8sm2320308wmf.45.2020.02.19.01.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 01:47:04 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] gpiolib: use gpiochip_get_desc() where applicable Date: Wed, 19 Feb 2020 10:47:02 +0100 Message-Id: <20200219094702.6463-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski Whenever retrieving a descriptor from a gpiochip: use the provided helper which checks for errors. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpiolib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 4d0106ceeba7..5c761a738065 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -2953,7 +2953,9 @@ const char *gpiochip_is_requested(struct gpio_chip *chip, unsigned offset) if (offset >= chip->ngpio) return NULL; - desc = &chip->gpiodev->descs[offset]; + desc = gpiochip_get_desc(chip, offset); + if (IS_ERR(desc)) + return NULL; if (test_bit(FLAG_REQUESTED, &desc->flags) == 0) return NULL; -- 2.25.0