From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: yu kuai <yukuai3@huawei.com>,
clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
zhengbin13@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH 2/3] btrfs: remove set but not used variable 'parent'
Date: Wed, 19 Feb 2020 15:17:30 +0100 [thread overview]
Message-ID: <20200219141730.GX2902@suse.cz> (raw)
In-Reply-To: <f7bc478c-2fe9-2694-cd0c-92c188d178c5@suse.com>
On Wed, Feb 19, 2020 at 01:34:53PM +0200, Nikolay Borisov wrote:
>
>
> On 19.02.20 г. 13:22 ч., yu kuai wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > fs/btrfs/tree-log.c: In function ‘walk_down_log_tree’:
> > fs/btrfs/tree-log.c:2702:24: warning: variable ‘parent’
> > set but not used [-Wunused-but-set-variable]
> > fs/btrfs/tree-log.c: In function ‘walk_up_log_tree’:
> > fs/btrfs/tree-log.c:2803:26: warning: variable ‘parent’
> > set but not used [-Wunused-but-set-variable]
> >
> > They are never used, and so can be removed.
> >
> > Signed-off-by: yu kuai <yukuai3@huawei.com>
>
> Ah yes, those two are a result of my :
>
> e084c5ab48f9 ("btrfs: Call btrfs_pin_reserved_extent only during active
> transaction") (in misc-next branch)
>
> David perhaps you can squash the two var removals into the original patch?
Yes I'll do that.
prev parent reply other threads:[~2020-02-19 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 11:22 yu kuai
2020-02-19 11:34 ` Nikolay Borisov
2020-02-19 14:17 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219141730.GX2902@suse.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome