From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6187FC11D05 for ; Thu, 20 Feb 2020 13:47:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34E5C222C4 for ; Thu, 20 Feb 2020 13:47:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="MtgKWlPn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728212AbgBTNrE (ORCPT ); Thu, 20 Feb 2020 08:47:04 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:54340 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728132AbgBTNrE (ORCPT ); Thu, 20 Feb 2020 08:47:04 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A7EBF563; Thu, 20 Feb 2020 14:47:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1582206422; bh=uiVkPCvjcZdbiY3qcGURFlvVQ3c1CcE3A2NnKP1Gewo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MtgKWlPnwMeA86TLEK/5cvysfXWA1tk4Oq5Bi3hPaI8PFUv6u74R4gH6iBbDBz+lv 9yuMr9/Yg1uwc31+VVI6mNTWIZbC+aCmorWGlxualPlBre5pNvFD2tQ36tJeb1ubBl ezWEmwz7OYlmwBlMRm4wDz3G54bdiGesQx1R2xVU= Date: Thu, 20 Feb 2020 15:46:43 +0200 From: Laurent Pinchart To: Vasily Khoruzhick Cc: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Icenowy Zheng , Torsten Duwe , Heiko Stuebner , Linus Walleij , Stephan Gerhold , Mark Brown , Stephen Rothwell , Samuel Holland , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/6] drm/bridge: anx6345: Fix getting anx6345 regulators Message-ID: <20200220134643.GB4998@pendragon.ideasonboard.com> References: <20200220083508.792071-1-anarsoul@gmail.com> <20200220083508.792071-2-anarsoul@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200220083508.792071-2-anarsoul@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vasily, Thank you for the patch. On Thu, Feb 20, 2020 at 12:35:03AM -0800, Vasily Khoruzhick wrote: > From: Samuel Holland > > We don't need to pass '-supply' suffix to devm_get_regulator() > > Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support") > Signed-off-by: Samuel Holland > Signed-off-by: Vasily Khoruzhick Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > index 56f55c53abfd..0d8d083b0207 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > @@ -712,14 +712,14 @@ static int anx6345_i2c_probe(struct i2c_client *client, > DRM_DEBUG("No panel found\n"); > > /* 1.2V digital core power regulator */ > - anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply"); > + anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12"); > if (IS_ERR(anx6345->dvdd12)) { > DRM_ERROR("dvdd12-supply not found\n"); > return PTR_ERR(anx6345->dvdd12); > } > > /* 2.5V digital core power regulator */ > - anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply"); > + anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25"); > if (IS_ERR(anx6345->dvdd25)) { > DRM_ERROR("dvdd25-supply not found\n"); > return PTR_ERR(anx6345->dvdd25); -- Regards, Laurent Pinchart