From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F6B7C11D0B for ; Thu, 20 Feb 2020 15:52:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6443820659 for ; Thu, 20 Feb 2020 15:52:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ibHAPK4d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728541AbgBTPwD (ORCPT ); Thu, 20 Feb 2020 10:52:03 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:54492 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728289AbgBTPwC (ORCPT ); Thu, 20 Feb 2020 10:52:02 -0500 Received: by mail-pj1-f65.google.com with SMTP id dw13so1041643pjb.4; Thu, 20 Feb 2020 07:52:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ee8gYjz2/NK3zQLUacTfzriK0f627854wQ+fW/DiGas=; b=ibHAPK4dZOkBgSjnYOBBy1bLrcL86MaTk6ozB+/+/v8Xwo8BhyjNmuNYQm8JzD9Kg1 5qG1SG+eGRtqdVDZaRz3YBTeI3csa558ewIUOxhTilOF82ambXFO1eF3nzmQR7ROjkqH DtQLxVIS4Hh/rcU2k45+k6FOjn4yqmDpidLwAps1ftNYSIYe0TMegSiW2c/aAGt/g+m2 E0wuYiXYNhNRh2R7je4UeLXVI7YDIRSX+pm4jUs7bzppXuX++6H0E/qUGwGWX9r31Jaa eKLN3CuaVPywV1DXlfeAozmFoB6+G5Pwu/OHVikR1rZZqmjj3biGrCHtQYdAz4z+oPwM w4BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Ee8gYjz2/NK3zQLUacTfzriK0f627854wQ+fW/DiGas=; b=hk68NHlYUl0byLAPBd5xxF2exl9A/458xjWSVRsWvSP/5R2B00NqVGYEYwkQc7flC0 ZLdpQ5hB6Y/MC7iWNzlNza2S/tbHy/3/9zyAgPzhQsm3Sd0+rQKOI8/gJl+02dCU8dJn TY8FvrMIwmc8pv11bpwpfzb1+tr3GOktIG/eJX0pep6ZAXqfxuRbrCyl9OpjFRoSFzIE +RExnVvXJXYI0DVw+sZHqsdmDs3Q7qRYaBMtEjisbT1arf3CqVKB/9sxa7+QeGqXCfRh JaECTjY5G6aUrWBAQZ/n0hPrJPwQkYcxYnV0vXr/DYMST3gbWW5o0kcAMkMreO78n/Ki TKRg== X-Gm-Message-State: APjAAAWJtbgITJGU4MwoeU6H44zu2RU6gUVHmxgSzD2E/w+uFJX5n6wr XFINqrBSJYJgKRCIjPNxTF0= X-Google-Smtp-Source: APXvYqwEM87xdIwcka2RcS2+volC1263cunDaDInFyyuPNjsIvj3zzwsaqK+yOuYzvDmBnMgIWiUxA== X-Received: by 2002:a17:902:223:: with SMTP id 32mr32169684plc.167.1582213922023; Thu, 20 Feb 2020 07:52:02 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id f13sm4207582pgk.12.2020.02.20.07.52.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Feb 2020 07:52:00 -0800 (PST) Date: Thu, 20 Feb 2020 07:52:00 -0800 From: Guenter Roeck To: Evan Benn Cc: LKML , Julius Werner , Bjorn Andersson , Mauro Carvalho Chehab , Marcin Juszkiewicz , Catalin Marinas , Olof Johansson , Leonard Crestez , Jonathan Cameron , Dinh Nguyen , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Will Deacon , linux-watchdog@vger.kernel.org, Rob Herring , Wim Van Sebroeck , =?iso-8859-1?Q?Cl=E9ment_P=E9ron?= , Shawn Guo , "David S. Miller" , Anson Huang Subject: Re: [PATCH 2/2] watchdog: Add new arm_smc_wdt watchdog driver Message-ID: <20200220155159.GB29658@roeck-us.net> References: <20200214062637.216209-1-evanbenn@chromium.org> <20200214172512.2.I7c8247c29891a538f258cb47828d58acf22c95a2@changeid> <804d3cc5-688d-7025-cb87-10b9616f4d9b@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 20, 2020 at 05:50:03PM +1100, Evan Benn wrote: > > > + if ((int)res->a0 == PSCI_RET_NOT_SUPPORTED) > > > + return -ENOTSUPP; > > > > -ENODEV would be better here. > > > > > + if ((int)res->a0 == PSCI_RET_INVALID_PARAMS) > > > + return -EINVAL; > > > + if ((int)res->a0 < 0) > > > + return -EIO; > > In fixing this I found drivers/firmware/psci/psci.c:145 > Which also translates psci codes to errno codes, but uses EOPNOTSUPP: > > switch (errno) { > case PSCI_RET_SUCCESS: > return 0; > case PSCI_RET_NOT_SUPPORTED: > return -EOPNOTSUPP; > case PSCI_RET_INVALID_PARAMS: > case PSCI_RET_INVALID_ADDRESS: > return -EINVAL; > case PSCI_RET_DENIED: > return -EPERM; > }; > > return -EINVAL; > > Are these more appropriate? > It is customary for driver probe functions to return -ENODEV if the device is not supported. I don't see a reason why this driver should behave any different. "but this other driver does it" is never a good argument. Having said that, yet, with the exception of -EOPNOTSUPP the other return values would be more appropriate. Guenter