From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F7FC35646 for ; Fri, 21 Feb 2020 19:22:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB154208E4 for ; Fri, 21 Feb 2020 19:22:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729769AbgBUTWr (ORCPT ); Fri, 21 Feb 2020 14:22:47 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:40284 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726423AbgBUTWr (ORCPT ); Fri, 21 Feb 2020 14:22:47 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E95FC141C8A41; Fri, 21 Feb 2020 11:22:46 -0800 (PST) Date: Fri, 21 Feb 2020 11:22:44 -0800 (PST) Message-Id: <20200221.112244.1426580944977593272.davem@davemloft.net> To: viro@zeniv.linux.org.uk Cc: torvalds@linux-foundation.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: Re: [RFC] regset ->get() API From: David Miller In-Reply-To: <20200221185903.GA3929948@ZenIV.linux.org.uk> References: <20200221033016.GV23230@ZenIV.linux.org.uk> <20200221185903.GA3929948@ZenIV.linux.org.uk> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 21 Feb 2020 11:22:47 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Al Viro Date: Fri, 21 Feb 2020 18:59:03 +0000 > Again, a couple of copy_regset_to_user(), but there's an additional > twist - GETREGSET of 32bit task on sparc64 will use access_process_vm() > when trying to fetch L0..L7/I0..I7 of other task, using copy_from_user() > only when the target is equal to current. For sparc32 this is not > true - it's always copy_from_user() there, so the values it reports > for those registers have nothing to do with the target process. That > part smells like a bug; by the time GETREGSET had been introduced > sparc32 was not getting much attention, GETREGS worked just fine > (not reporting L*/I* anyway) and for coredump it was accessing the > caller's memory. Not sure if anyone cares at that point... That's definitely a bug and sparc64 is doing it correctly.