From: Torsten Duwe <duwe@lst.de>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Vasily Khoruzhick <anarsoul@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Thierry Reding <treding@nvidia.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
Sean Paul <seanpaul@chromium.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Maxime Ripard <maxime@cerno.tech>
Subject: Re: [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal
Date: Fri, 21 Feb 2020 16:01:17 +0100 [thread overview]
Message-ID: <20200221150117.GA6928@lst.de> (raw)
In-Reply-To: <b30435c7-95c5-e21e-ea05-cd3ada20d150@suse.de>
On Fri, Feb 21, 2020 at 03:39:32PM +0100, Thomas Zimmermann wrote:
> Hi Torsten
>
> Am 21.02.20 um 15:04 schrieb Torsten Duwe:
> > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
> > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0]
> > and the multiply+divide alltogether.
> >
> > fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5")
>
> You have to create the fixes tag and related cc tags with 'dim fixes',
> available at [1]. For this patch, the output is
>
> Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5")
> Cc: Torsten Duwe <duwe@suse.de>
> Cc: Maxime Ripard <maxime@cerno.tech>
> Cc: Torsten Duwe <duwe@lst.de>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Icenowy Zheng <icenowy@aosc.io>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Ah, neat.
> > Signed-off-by: Torsten Duwe <duwe@suse.de>
>
> You signed off with your SUSE email address, but sent the mail from
> lst.de. I don't know if it's strictly not allowed, but that's at least
> confusing to the tools.
From my understanding, it is legally correct. The work is owned by Suse,
so I have to sign off as an employee, but I'm subscribed with the LST
address, and I'd also like to see all replies there.
> [1] https://gitlab.freedesktop.org/drm/maintainer-tools/
I'll send an appropriate v2 once I get a review for it.
Thanks!
Torsten
next prev parent reply other threads:[~2020-02-21 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 14:04 Torsten Duwe
2020-02-21 14:39 ` Thomas Zimmermann
2020-02-21 15:01 ` Torsten Duwe [this message]
2020-02-21 15:05 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221150117.GA6928@lst.de \
--to=duwe@lst.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=anarsoul@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®