From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E9AEC35669 for ; Sat, 22 Feb 2020 10:06:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D49D20656 for ; Sat, 22 Feb 2020 10:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727158AbgBVKFs convert rfc822-to-8bit (ORCPT ); Sat, 22 Feb 2020 05:05:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:48310 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726675AbgBVKFs (ORCPT ); Sat, 22 Feb 2020 05:05:48 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7357CADF8; Sat, 22 Feb 2020 10:05:46 +0000 (UTC) Date: Sat, 22 Feb 2020 11:05:45 +0100 From: Thomas Bogendoerfer To: Jacek Anaszewski Cc: Pavel Machek , Dan Murphy , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v4] leds: add SGI IP30 led support Message-Id: <20200222110545.fc96683543cb0dd538e5be82@suse.de> In-Reply-To: <49524a9a-910a-9f1a-bc10-d78080a16d46@gmail.com> References: <20200221111120.28799-1-tbogendoerfer@suse.de> <49524a9a-910a-9f1a-bc10-d78080a16d46@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Feb 2020 21:31:04 +0100 Jacek Anaszewski wrote: > > + if (num == 0) > > + data->cdev.name = "white:indicator"; > > + else > > + data->cdev.name = "red:indicator"; > > Why indicator? Whereas it sounds quite generic it is used in the LED > subsystem specifically for naming indicator LEDs, that are often > found on flash LED controllers and are designed to indicate camera > sensor activity. ok, ic. > If it is on the front panel of SGI Octane workstations then its > function is perhaps well known? the red LED is clearly a fault led. The white LED will be switch on after system diagnostic was successfull. Nothing from common.h really fits that, maybe status ? Thomas. -- SUSE Software Solutions Germany GmbH HRB 36809 (AG Nürnberg) Geschäftsführer: Felix Imendörffer