From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B258DC35670 for ; Sun, 23 Feb 2020 23:19:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AD3A20880 for ; Sun, 23 Feb 2020 23:19:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kOHPuzo7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727314AbgBWXSG (ORCPT ); Sun, 23 Feb 2020 18:18:06 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:54059 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727207AbgBWXSE (ORCPT ); Sun, 23 Feb 2020 18:18:04 -0500 Received: by mail-wm1-f65.google.com with SMTP id s10so7189021wmh.3; Sun, 23 Feb 2020 15:18:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E9qoESjMSRYNcvQKoiebYJwkNHkC7X+DjeOLcXKDFb0=; b=kOHPuzo7yRvDL0CSR3L3FVOHcuUyS2HF7lfRacoZjsAC9U55y/H35V4Xz7TMjyCuB8 SLlg1PzzD6caSS8mC40bWVphpHGUOAsvkGzkg/vv+YutF2pGfcKHsO610FniwwAoo9eq NhGPTN6Y4xW2Va/irlLAKt/IfMJ0SxswYZ/kQd482UtNlXhHNl9WoCpNZBSScltJLN42 cdTV512+VDp6Tg/YzSg0YLBPgsE3K5uQb1UiGtUE6/xcwqxVXuU5eM/l23NHTBABnOXM 1bGK/92rB65v3G1fRTVyoutXBSXF6EcboYFp3t+c24I8vn0oJfIMbxTOAe2iING4yBEF BtKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E9qoESjMSRYNcvQKoiebYJwkNHkC7X+DjeOLcXKDFb0=; b=NLUHxWfUBcgT0TwMtaEVMItflb7FME8Z1H+CpIIYQheEr/swfW5xh9SFQVjD8ixNXY l4r4uaK1oZNkfWd8Tzoo/fTy3OZEq98x7FMYy9iaHzzzszlGYtS4YINGeoPqvvP7zKKa voYbbI1pV38A7900pmNvgK+t7XJjcm16zDq6DQkGDhIZh8fRfOE39XLIPVNhBCAv5fbD id/NUOpL9vPJTqpoor2btjuSpbvWyiRS9etsXy5SwD6AXwkapaZ2eGr9EWwbY5GsAFvR VfnBl9R73QLSLfbGRGZEdPb9RzQE3JRIfPFITJAzspttpLgs2OvHUWkToWIXljTzT85K jqRw== X-Gm-Message-State: APjAAAXWtXpzFNgdxVvZZjHJ0865ppEMj2r4xdCzwlxd60775f7w2sRI +tXNtNrBwz0M5bjLJywOcQ== X-Google-Smtp-Source: APXvYqwkgs56LmghiFd5vgbeFjZ5KlBwjNOKxFCiaACm218hRs56Op9pBLv1+bwyArnr/O1AlB2bRQ== X-Received: by 2002:a7b:cb46:: with SMTP id v6mr19194918wmj.117.1582499881880; Sun, 23 Feb 2020 15:18:01 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id q6sm8968203wrf.67.2020.02.23.15.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2020 15:18:01 -0800 (PST) From: Jules Irenge To: boqun.feng@gmail.com Cc: jbi.octave@gmail.com, linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org (open list:LLC (802.2)) Subject: [PATCH 07/30] net: Add missing annotation for llc_seq_start() Date: Sun, 23 Feb 2020 23:16:48 +0000 Message-Id: <20200223231711.157699-8-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200223231711.157699-1-jbi.octave@gmail.com> References: <0/30> <20200223231711.157699-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning at llc_seq_start() warning: context imbalance in llc_seq_start() - wrong count at exit The root cause is the msiing annotation at llc_seq_start() Add the missing __acquires(RCU) annotation Signed-off-by: Jules Irenge --- net/llc/llc_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/llc/llc_proc.c b/net/llc/llc_proc.c index f3a36c16a5e7..a4eccb98220a 100644 --- a/net/llc/llc_proc.c +++ b/net/llc/llc_proc.c @@ -56,7 +56,7 @@ static struct sock *llc_get_sk_idx(loff_t pos) return sk; } -static void *llc_seq_start(struct seq_file *seq, loff_t *pos) +static void *llc_seq_start(struct seq_file *seq, loff_t *pos) __acquires(RCU) { loff_t l = *pos; -- 2.24.1