From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CEC7C38BE0 for ; Mon, 24 Feb 2020 19:21:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2839A20836 for ; Mon, 24 Feb 2020 19:21:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727282AbgBXTVo (ORCPT ); Mon, 24 Feb 2020 14:21:44 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:36996 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbgBXTVo (ORCPT ); Mon, 24 Feb 2020 14:21:44 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CDF64120ED555; Mon, 24 Feb 2020 11:21:43 -0800 (PST) Date: Mon, 24 Feb 2020 11:21:43 -0800 (PST) Message-Id: <20200224.112143.2283025986833354811.davem@davemloft.net> To: colin.king@canonical.com Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, tanhuazhong@huawei.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] net: hns3: remove redundant initialization of pointer 'client' From: David Miller In-Reply-To: <20200224192022.407524-1-colin.king@canonical.com> References: <20200224192022.407524-1-colin.king@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 24 Feb 2020 11:21:44 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Mon, 24 Feb 2020 19:20:22 +0000 > From: Colin Ian King > > The pointer 'client' is being initialized with a value that is never > read, it is being updated later on. The initialization is redundant > and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > > V2: use reverse christmas tree ordering of local variables Applied to net-next, thanks Colin.