From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH 2/4] pwm: omap-dmtimer: Fix pwm enabling sequence
Date: Mon, 24 Feb 2020 09:49:56 +0100 [thread overview]
Message-ID: <20200224084956.wwsnf2y24ragg3vf@pengutronix.de> (raw)
In-Reply-To: <20200224052135.17278-3-lokeshvutla@ti.com>
On Mon, Feb 24, 2020 at 10:51:33AM +0530, Lokesh Vutla wrote:
> To configure DM timer is pwm mode the following needs to be set in
> OMAP_TIMER_CTRL_REG using set_pwm callback:
> - Set toggle mode on PORTIMERPWM output pin
> - Set trigger on overflow and match on PORTIMERPWM output pin.
> - Set auto reload
>
> This is a one time configuration and needs to be set before the start of
> the dm timer. But the current driver tries to set the same configuration
> for every period/duty cycle update, which is not needed. So move the pwm
> setup before enabling timer and do not update it in pwm_omap_dmtimer_config.
Is this change kind of moot with the conversion to .apply in the next
patch?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2020-02-24 8:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 5:21 [PATCH 0/4] pwm: omap-dmtimer: Allow for dynamic pwm period updates Lokesh Vutla
2020-02-24 5:21 ` [PATCH 1/4] pwm: omap-dmtimer: Drop unused header file Lokesh Vutla
2020-02-24 7:53 ` Uwe Kleine-König
2020-02-25 5:02 ` Lokesh Vutla
2020-02-25 6:43 ` Uwe Kleine-König
2020-02-24 5:21 ` [PATCH 2/4] pwm: omap-dmtimer: Fix pwm enabling sequence Lokesh Vutla
2020-02-24 8:49 ` Uwe Kleine-König [this message]
2020-02-25 5:02 ` Lokesh Vutla
2020-02-24 5:21 ` [PATCH 3/4] pwm: omap-dmtimer: Do not disable pwm before changing period/duty_cycle Lokesh Vutla
2020-02-24 8:55 ` Uwe Kleine-König
2020-02-25 5:02 ` Lokesh Vutla
2020-02-25 6:48 ` Uwe Kleine-König
2020-02-25 7:59 ` Lokesh Vutla
2020-02-25 8:38 ` Uwe Kleine-König
2020-02-25 11:26 ` Lokesh Vutla
2020-02-26 16:35 ` Uwe Kleine-König
2020-02-24 5:21 ` [PATCH 4/4] pwm: omap-dmtimer: Implement .apply callback Lokesh Vutla
2020-02-24 9:07 ` Uwe Kleine-König
2020-02-25 5:01 ` Lokesh Vutla
2020-02-26 16:21 ` Uwe Kleine-König
2020-02-26 17:57 ` [PATCH 0/4] pwm: omap-dmtimer: Allow for dynamic pwm period updates Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224084956.wwsnf2y24ragg3vf@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nsekhar@ti.com \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®