From: Maxime Ripard <maxime@cerno.tech>
To: Chen-Yu Tsai <wens@csie.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Allwinner sunXi SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: sun8i-a83t: Add thermal trip points/cooling maps
Date: Mon, 24 Feb 2020 10:20:20 +0100 [thread overview]
Message-ID: <20200224092020.xxru2rkhrywonrx7@gilmour.lan> (raw)
In-Reply-To: <20200223101050.lqe5uegpmoyqvna6@core.my.home>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On Sun, Feb 23, 2020 at 11:10:50AM +0100, Ondřej Jirman wrote:
> Hello,
>
> On Sun, Feb 23, 2020 at 11:29:07AM +0800, Chen-Yu Tsai wrote:
> > Hi,
> >
> > On Sun, Feb 23, 2020 at 5:40 AM Ondrej Jirman <megous@megous.com> wrote:
> > >
> > > This enables passive cooling by down-regulating CPU voltage
> > > and frequency.
> >
> > Please state for the record how the trip points were derived. Were they from
> > the BSP? Or the user manual?
>
> The values are taken from the BSP for A83T:
>
> https://megous.com/git/linux/tree/drivers/thermal/sunxi-temperature.c?h=a83t-3.4-bsp-tbs-a711#n747
>
> The datasheet only mentions recommended Ta (ambient operating temperature) range
> -20 to +70°C. So die voltages will be larger than that. I guess that roughly
> matches the BSP values.
Can you put that in the commit log?
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2020-02-24 9:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-22 21:40 Ondrej Jirman
2020-02-23 3:29 ` Chen-Yu Tsai
2020-02-23 10:10 ` Ondřej Jirman
2020-02-24 9:20 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224092020.xxru2rkhrywonrx7@gilmour.lan \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®