mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org, Borislav Petkov <bp@suse.de>,
	x86 <x86@kernel.org>
Subject: Re: [tip: x86/kdump] x86/kexec: Do not reserve EFI setup_data in the kexec e820 table
Date: Tue, 25 Feb 2020 09:49:12 +0800	[thread overview]
Message-ID: <20200225014912.GA13800@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <158254146897.28353.4247096498069522547.tip-bot2@tip-bot2>

On 02/24/20 at 10:51am, tip-bot2 for Dave Young wrote:
> The following commit has been merged into the x86/kdump branch of tip:
> 
> Commit-ID:     8efbc518b884e1db2dd6a6fce62d0112ab871dcf
> Gitweb:        https://git.kernel.org/tip/8efbc518b884e1db2dd6a6fce62d0112ab871dcf
> Author:        Dave Young <dyoung@redhat.com>
> AuthorDate:    Wed, 12 Feb 2020 19:04:24 +08:00
> Committer:     Borislav Petkov <bp@suse.de>
> CommitterDate: Mon, 24 Feb 2020 11:41:57 +01:00
> 
> x86/kexec: Do not reserve EFI setup_data in the kexec e820 table
> 
> The e820 table for the kexec kernel unconditionally marks setup_data as
> reserved because the second kernel can reuse setup_data passed by the
> 1st kernel's boot loader, for example SETUP_PCI marked regions like PCI
> BIOS, etc.
> 
> SETUP_EFI types, however, are used by kexec itself to enable EFI in the
> 2nd kernel. Thus, it is pointless to add this type of setup_data to the
> kexec e820 table as reserved.
> 
> IOW, what happens is this:
> 
>   -  1st physical boot: no SETUP_EFI.
> 
>   - kexec loads a new kernel and prepares a SETUP_EFI setup_data blob, then
>   reboots the machine.
> 
>   - 2nd kernel sees SETUP_EFI, reserves it both in the e820 and in the
>   kexec e820 table.
> 
>   - If another kexec load is executed, it prepares a new SETUP_EFI blob and
>   then reboots the machine into the new kernel.
> 
>   5. The 3rd kexec-ed kernel has two SETUP_EFI ranges reserved. And so on...
> 
> Thus skip SETUP_EFI while reserving setup_data in the e820_table_kexec
> table because it is not needed.
> 
>  [ bp: Heavily massage commit message, shorten line and improve comment. ]

Boris, thanks for the amending and log massage.
I was hesitating to break the long line or not and then I choosed
leaving it as is.  Both are not very good and either of them is fine to me.

Thanks
Dave


      reply	other threads:[~2020-02-25  1:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 11:04 [PATCH] x86/kexec: do not reserve kexec setup_data in " Dave Young
2020-02-24  7:14 ` Dave Young
2020-02-24 10:51 ` [tip: x86/kdump] x86/kexec: Do not reserve EFI setup_data in the " tip-bot2 for Dave Young
2020-02-25  1:49   ` Dave Young [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200225014912.GA13800@dhcp-128-65.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=bp@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®