From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH v1 1/3] nvmem: Add support for write-only instances
Date: Tue, 25 Feb 2020 17:43:43 +0200 [thread overview]
Message-ID: <20200225154343.GG2667@lahna.fi.intel.com> (raw)
In-Reply-To: <PSXP216MB0438D95E25CA8BA02A40735480ED0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
On Tue, Feb 25, 2020 at 03:30:22PM +0000, Nicholas Johnson wrote:
> > Actually I think maybe we make this one only writeable by root, in other
> > words it would always require ->root_only to be set.
> There is a world-accessible rw entry already, which would, if anything,
> be even more dangerous than a world writable entry. However, there could
> be a hypothetical use case. I agree it is unlikely to be required, but
> who knows?
You mean 0644 entry? That should be fine as it is not writable by anyone
else than the owner (root in this case).
> Based on your statement that no sysfs should ever be world-writable,
> should I be trying to remove the world-accessible rw as well?
No I don't think it is necesary. Just let's not add attributes that
anyone can write without good reasoning ;-)
next prev parent reply other threads:[~2020-02-25 15:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 17:41 [PATCH v1 0/3] nvmem: Add support for write-only instances, and clean-up Nicholas Johnson
2020-02-24 17:42 ` [PATCH v1 1/3] nvmem: Add support for write-only instances Nicholas Johnson
2020-02-25 12:51 ` Mika Westerberg
2020-02-25 15:30 ` Nicholas Johnson
2020-02-25 15:43 ` Mika Westerberg [this message]
2020-02-27 14:46 ` Nicholas Johnson
2020-02-24 17:43 ` [PATCH v1 2/3] Revert "thunderbolt: Prevent crash if non-active NVMem file is read" Nicholas Johnson
2020-02-25 12:56 ` Mika Westerberg
2020-02-25 15:33 ` Nicholas Johnson
2020-02-25 15:44 ` Mika Westerberg
2020-02-24 17:43 ` [PATCH v1 3/3] nvmem: Remove .read_only field from nvmem_config Nicholas Johnson
2020-02-25 1:19 ` kbuild test robot
2020-02-25 10:49 ` Nicholas Johnson
2020-02-25 14:59 ` [PATCH v1 0/3] nvmem: Add support for write-only instances, and clean-up Srinivas Kandagatla
2020-02-25 15:23 ` Nicholas Johnson
2020-02-25 17:04 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225154343.GG2667@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome