From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCE75C4BA13 for ; Wed, 26 Feb 2020 14:02:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEED32467B for ; Wed, 26 Feb 2020 14:02:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727127AbgBZOCo (ORCPT ); Wed, 26 Feb 2020 09:02:44 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:41342 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726151AbgBZOCo (ORCPT ); Wed, 26 Feb 2020 09:02:44 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id CD3EA1C204C; Wed, 26 Feb 2020 15:02:41 +0100 (CET) Date: Wed, 26 Feb 2020 15:02:41 +0100 From: Pavel Machek To: Greg Kroah-Hartman Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jacek Anaszewski , Dan Murphy , Jiri Slaby , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-serial@vger.kernel.org Subject: Re: [PATCH v6 0/4] leds: trigger: implement a tty trigger Message-ID: <20200226140241.GI4080@duo.ucw.cz> References: <20200213091600.554-1-uwe@kleine-koenig.org> <20200219104012.GA2814125@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PWfwoUCx3AFJRUBq" Content-Disposition: inline In-Reply-To: <20200219104012.GA2814125@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PWfwoUCx3AFJRUBq Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2020-02-19 11:40:12, Greg Kroah-Hartman wrote: > On Thu, Feb 13, 2020 at 10:15:56AM +0100, Uwe Kleine-K=F6nig wrote: > > From: Uwe Kleine-K=F6nig > >=20 > > Hello, > >=20 > > This is v6 of my quest to introduce ledtriggers for UARTs. The previous > > series is available at > >=20 > > http://lore.kernel.org/r/20191219093947.15502-1-u.kleine-koenig@pengut= ronix.de > >=20 > > The changes compared to that are that parsing of the dev parameter is > > more strict and that I set brightness directly from the kworker instead > > of using led_blink_set_oneshot which makes use of another kworker. (Both > > requested by Pavel Machek.) > >=20 > > For the former I introduced a new helper kstrtodev_t() in the spirit of > > kstrtoul() to implement the stricter parsing (instead of the lax one > > using plain sscanf() in v5). >=20 > Looks good to me, Pavel, any objection to me merging this through the > tty tree? I see ton of comments on this one, seems like there will be one more version? And I fear merge conflicts if you modify drivers/leds/Makefile... Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --PWfwoUCx3AFJRUBq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXlZ6gQAKCRAw5/Bqldv6 8n1kAJ0eHl7DmssrmBA95ietDxnHxPLc3gCgnoJOhR7lBDQxmSrvzu5d+xnLKVA= =yHGr -----END PGP SIGNATURE----- --PWfwoUCx3AFJRUBq--