From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E73C3C4BA13 for ; Wed, 26 Feb 2020 14:59:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9DC320838 for ; Wed, 26 Feb 2020 14:59:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727044AbgBZO7g (ORCPT ); Wed, 26 Feb 2020 09:59:36 -0500 Received: from elvis.franken.de ([193.175.24.41]:38970 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726063AbgBZO7g (ORCPT ); Wed, 26 Feb 2020 09:59:36 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1j6y9t-0001cq-00; Wed, 26 Feb 2020 15:59:33 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 4FF4BC0E99; Wed, 26 Feb 2020 15:59:17 +0100 (CET) Date: Wed, 26 Feb 2020 15:59:17 +0100 From: Thomas Bogendoerfer To: Paul Cercueil Cc: Paul Burton , od@zcrc.me, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] MIPS: Fix CONFIG_MIPS_CMDLINE_DTB_EXTEND handling Message-ID: <20200226145917.GA12722@alpha.franken.de> References: <20200225152810.45048-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200225152810.45048-1-paul@crapouillou.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 25, 2020 at 12:28:09PM -0300, Paul Cercueil wrote: > The CONFIG_MIPS_CMDLINE_DTB_EXTEND option is used so that the kernel > arguments provided in the 'bootargs' property in devicetree are extended > with the kernel arguments provided by the bootloader. > > The code was broken, as it didn't actually take any of the kernel > arguments provided in devicetree when that option was set. > > Fixes: 7784cac69735 ("MIPS: cmdline: Clean up boot_command_line > initialization") > Cc: stable@vger.kernel.org > Signed-off-by: Paul Cercueil > --- > arch/mips/kernel/setup.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]