From: Tony Lindgren <tony@atomide.com>
To: Suman Anna <s-anna@ti.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Tero Kristo <t-kristo@ti.com>,
Neil Armstrong <narmstrong@baylibre.com>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Keerthy <j-keerthy@ti.com>, Ladislav Michl <ladis@linux-mips.org>,
Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH] clocksource: timer-ti-dm: Drop bogus omap_dm_timer_of_set_source()
Date: Wed, 26 Feb 2020 08:16:02 -0800 [thread overview]
Message-ID: <20200226161602.GO37466@atomide.com> (raw)
In-Reply-To: <20200213053504.22638-1-s-anna@ti.com>
* Suman Anna <s-anna@ti.com> [200212 21:36]:
> Hi Tony,
>
> Do you have the history of why the 32 KHz source is set as parent during
> prepare? One of the current side-affects of this patch is that now instead
> of bailing out, the 32 KHz source is set, and consumers will still need
> to select their appropriate parent. Dropping that call should actually
> allow us to select the parents in the consumer nodes in dts files using
> the assigned-clocks and assigned-clock-parents properties. I prefer to
> drop it if you do not foresee any issues. For now, I do not anticipate
> any issues with omap-pwm-dmtimer with this patch.
Using the 32 KiHz source works better for PM. But yeah the
machine specific source clock should be configured with
assigned-clocks and assigned-clock-parents properites.
Things seem to behave just fine for me with this patch for both
pwm-leds and PM. Good to see this function gone:
Tested-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2020-02-26 16:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 5:35 Suman Anna
2020-02-24 5:01 ` Lokesh Vutla
2020-02-26 16:16 ` Tony Lindgren [this message]
2020-02-26 17:24 ` Daniel Lezcano
2020-02-27 9:33 ` Daniel Lezcano
2020-03-19 8:47 ` [tip: timers/core] clocksource/drivers/timer-ti-dm: " tip-bot2 for Suman Anna
2020-04-25 9:14 ` [PATCH] clocksource: timer-ti-dm: " Lokesh Vutla
2020-04-25 14:51 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226161602.GO37466@atomide.com \
--to=tony@atomide.com \
--cc=bgolaszewski@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=hns@goldelico.com \
--cc=j-keerthy@ti.com \
--cc=ladis@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=pavel@ucw.cz \
--cc=s-anna@ti.com \
--cc=sre@kernel.org \
--cc=t-kristo@ti.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome