From: Pavel Machek <pavel@denx.de>
To: ycho1399@gmail.com
Cc: linux-input@vger.kernel.org, voyandrea@gmail.com,
andrea.ho@advantech.com.tw, oakley.ding@advantech.com.tw,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Luca Weiss <luca@z3ntu.xyz>,
Maximilian Luz <luzmaximilian@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [V1,1/1] Input/misc: add support for Advantech software defined button
Date: Thu, 27 Feb 2020 09:56:17 +0100 [thread overview]
Message-ID: <20200227085617.GA16021@duo.ucw.cz> (raw)
In-Reply-To: <20200227031721.17703-1-Andrea.Ho@advantech.com.tw>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
On Thu 2020-02-27 03:15:31, ycho1399@gmail.com wrote:
> From: "Andrea.Ho" <Andrea.Ho@advantech.com.tw>
>
> Advantech sw_button is a ACPI event trigger button.
>
> With this driver, we can report KEY_EVENTs on the
> Advantech Tabletop Network Appliances products and it has been
> tested in FWA1112VC.
>
> Add the software define button support to report KEY_EVENTs by
> different acts of pressing button (like double-click, long pressed
> and tick) that cloud be get on user interface and trigger the
> customized actions.
I'm not sure why you Cc half of the world. What does Dave Miller have
to do with this. Please be more careful (and drop me from the list).
Plus, I'm pretty sure you should not be detecting double clicks (etc)
in the driver.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2020-02-27 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 3:15 ycho1399
2020-02-27 7:22 ` Greg Kroah-Hartman
2020-02-27 8:11 ` Joe Perches
2020-02-27 8:56 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227085617.GA16021@duo.ucw.cz \
--to=pavel@denx.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=andrea.ho@advantech.com.tw \
--cc=bgolaszewski@baylibre.com \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=luzmaximilian@gmail.com \
--cc=mchehab+samsung@kernel.org \
--cc=oakley.ding@advantech.com.tw \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=voyandrea@gmail.com \
--cc=ycho1399@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®