mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: jolsa@redhat.com, xieyisheng1@huawei.com,
	alexey.budankov@linux.intel.com, treeze.taeung@gmail.com,
	adrian.hunter@intel.com, tmricht@linux.ibm.com,
	namhyung@kernel.org, irogers@google.com, songliubraving@fb.com,
	yao.jin@linux.intel.com, changbin.du@intel.com,
	leo.yan@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] perf annotate/tui: Re-render title bar after switching back from script browser
Date: Thu, 27 Feb 2020 10:11:00 -0300	[thread overview]
Message-ID: <20200227131100.GB9899@kernel.org> (raw)
In-Reply-To: <20200213064306.160480-2-ravi.bangoria@linux.ibm.com>

Em Thu, Feb 13, 2020 at 12:12:59PM +0530, Ravi Bangoria escreveu:
> Perf annotate tui browser provides a hot key 'r' to switch to script
> browser. But the annotate browser title bar becomes hidden while
> switching back from script browser. Fix it.

Reproduced, tested fix, applied, thanks.

- Arnaldo
 
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> ---
>  tools/perf/ui/browsers/annotate.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
> index badbddbb30f8..0dbbf35e6ed1 100644
> --- a/tools/perf/ui/browsers/annotate.c
> +++ b/tools/perf/ui/browsers/annotate.c
> @@ -754,10 +754,9 @@ static int annotate_browser__run(struct annotate_browser *browser,
>  		"?             Search string backwards\n");
>  			continue;
>  		case 'r':
> -			{
> -				script_browse(NULL, NULL);
> -				continue;
> -			}
> +			script_browse(NULL, NULL);
> +			annotate_browser__show(&browser->b, title, help);
> +			continue;
>  		case 'k':
>  			notes->options->show_linenr = !notes->options->show_linenr;
>  			break;
> -- 
> 2.24.1
> 

-- 

- Arnaldo

  reply	other threads:[~2020-02-27 13:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13  6:42 [PATCH 0/8] perf annotate/config: More fixes Ravi Bangoria
2020-02-13  6:42 ` [PATCH 1/8] perf annotate/tui: Re-render title bar after switching back from script browser Ravi Bangoria
2020-02-27 13:11   ` Arnaldo Carvalho de Melo [this message]
2020-02-29  9:16   ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13  6:43 ` [PATCH 2/8] perf annotate: Fix --show-total-period for tui/stdio2 Ravi Bangoria
2020-02-27 13:14   ` Arnaldo Carvalho de Melo
2020-02-29  9:16   ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13  6:43 ` [PATCH 3/8] perf annotate: Fix --show-nr-samples " Ravi Bangoria
2020-02-29  9:16   ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13  6:43 ` [PATCH 4/8] perf config: Introduce perf_config_u8() Ravi Bangoria
2020-02-29  9:16   ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13  6:43 ` [PATCH 5/8] perf annotate: Make perf config effective Ravi Bangoria
2020-02-27 13:32   ` Arnaldo Carvalho de Melo
2020-02-29  9:16   ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13  6:43 ` [PATCH 6/8] perf annotate: Prefer cmdline option over default config Ravi Bangoria
2020-02-29  9:16   ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13  6:43 ` [PATCH 7/8] perf annotate: Fix perf config option description Ravi Bangoria
2020-02-29  9:16   ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-13  6:43 ` [PATCH 8/8] perf config: Document missing config options Ravi Bangoria
2020-02-29  9:16   ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2020-02-16 21:15 ` [PATCH 0/8] perf annotate/config: More fixes Jiri Olsa
2020-02-17 13:02   ` Ravi Bangoria
2020-02-27 13:08   ` Arnaldo Carvalho de Melo
2020-02-27 13:16     ` Jiri Olsa
2020-02-27 13:43       ` Arnaldo Carvalho de Melo
2020-02-27 13:39 ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200227131100.GB9899@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=adrian.hunter@intel.com \
    --cc=alexey.budankov@linux.intel.com \
    --cc=changbin.du@intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=ravi.bangoria@linux.ibm.com \
    --cc=songliubraving@fb.com \
    --cc=tmricht@linux.ibm.com \
    --cc=treeze.taeung@gmail.com \
    --cc=xieyisheng1@huawei.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome