From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v5] leds: add SGI IP30 led support
Date: Thu, 27 Feb 2020 15:00:04 +0100 [thread overview]
Message-ID: <20200227150004.97154811ecbd2f5ccc22fa64@suse.de> (raw)
In-Reply-To: <20200226140058.GH4080@duo.ucw.cz>
On Wed, 26 Feb 2020 15:00:58 +0100
Pavel Machek <pavel@ucw.cz> wrote:
> > + switch (num) {
> > + case IP30_LED_SYSTEM:
> > + data->cdev.name = "white:system";
> > + break;
> > + case IP30_LED_FAULT:
> > + data->cdev.name = "red:fault";
> > + break;
>
> If the white LED normally serves as power indicator for the system, we
> might want to specify that. Does it?
it could be seen as such, but it will be turned on only after POST has finished
successfull. So it's off if POST failed, which doesn't make it a real power led
IMHO.
Thomas.
--
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Felix Imendörffer
prev parent reply other threads:[~2020-02-27 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 11:17 Thomas Bogendoerfer
2020-02-24 19:17 ` Jacek Anaszewski
2020-02-26 14:00 ` Pavel Machek
2020-02-27 14:00 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227150004.97154811ecbd2f5ccc22fa64@suse.de \
--to=tbogendoerfer@suse.de \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®