From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Gayatri Kammela <gayatri.kammela@intel.com>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, vishwanath.somayaji@intel.com,
dvhart@infradead.org, mika.westerberg@intel.com,
peterz@infradead.org, charles.d.prestopine@intel.com,
Chen Zhou <chenzhou10@huawei.com>,
"David E . Box" <david.e.box@intel.com>
Subject: Re: [PATCH v2 2/4] platform/x86: intel_pmc_core: fix: Make pmc_core_lpm_display() generic for platforms that support sub-states
Date: Fri, 28 Feb 2020 12:06:28 +0200 [thread overview]
Message-ID: <20200228100628.GJ1224808@smile.fi.intel.com> (raw)
In-Reply-To: <49e90f024d89746d5955331e023231149210917c.1582845395.git.gayatri.kammela@intel.com>
On Thu, Feb 27, 2020 at 03:29:14PM -0800, Gayatri Kammela wrote:
> Currently pmc_core_lpm_display() uses array of struct pointers i.e.,
> tgl_lpm_maps for Tiger Lake directly to iterate through and to get the
> number of status/live status registers which is hardcoded and cannot
> be re-used for future platforms that support sub-states. To maintain
> readability, make pmc_core_lpm_display() generic, so that it can re-used
> for future platforms.
This patch need more work, see below.
That said, I would prefer to see it last in the series for next version.
...
> + lpm_regs = kmalloc_array(arr_size, sizeof(*lpm_regs), GFP_KERNEL);
No error check?
Besides that it is obvious memory leak.
> + for (index = 0; maps[index]; index++) {
> lpm_regs[index] = pmc_core_reg_read(pmcdev, offset);
> offset += 4;
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-02-28 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 23:29 [PATCH v2 0/4] platform/x86: intel_pmc_core: Add bug fixes or code Gayatri Kammela
2020-02-27 23:29 ` [PATCH v2 1/4] platform/x86: intel_pmc_core: fix: Relocate pmc_core_slps0_display() and pmc_core_lpm_display() to outside of CONFIG_DEBUG_FS Gayatri Kammela
2020-02-27 23:29 ` [PATCH v2 2/4] platform/x86: intel_pmc_core: fix: Make pmc_core_lpm_display() generic for platforms that support sub-states Gayatri Kammela
2020-02-28 10:06 ` Andy Shevchenko [this message]
2020-02-28 17:33 ` Kammela, Gayatri
2020-02-27 23:29 ` [PATCH v2 3/4] platform/x86: intel_pmc_core: fix: Remove the duplicate if() to create debugfs entry for substate_live_status_registers Gayatri Kammela
2020-02-27 23:29 ` [PATCH v2 4/4] platform/x86: intel_pmc_core: fix: Add slp_s0_offset attribute back to tgl_reg_map Gayatri Kammela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228100628.GJ1224808@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=charles.d.prestopine@intel.com \
--cc=chenzhou10@huawei.com \
--cc=david.e.box@intel.com \
--cc=dvhart@infradead.org \
--cc=gayatri.kammela@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vishwanath.somayaji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®