From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E0DC3F2D2 for ; Fri, 28 Feb 2020 16:46:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C604E24697 for ; Fri, 28 Feb 2020 16:46:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iJrIjG+I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726687AbgB1Qp7 (ORCPT ); Fri, 28 Feb 2020 11:45:59 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40610 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725928AbgB1Qp7 (ORCPT ); Fri, 28 Feb 2020 11:45:59 -0500 Received: by mail-wr1-f66.google.com with SMTP id r17so3682359wrj.7 for ; Fri, 28 Feb 2020 08:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dnB3YbRslroktKcVWBmtkOUB1kEjE4Aqzh9tCjoW9sA=; b=iJrIjG+IiWYGIuv4aS0pjFrtNOSHON/kkOz+fiN9gPNqV/5tmaqI5quNYhYtXpecqj h0lPxpt0G2l3YPQbieYSSvsK9K1gO4106/0u8OWo7DnozluA3vQdUjQ7TMiPNXIbXNBF iTpUnf84x/8gy3ffZuQouprp9+Aa16QxOw013HNiv2Zr2ZTU0WKzVuFvxSZsDw9qO1y8 xDkWfOJbsUAe51FkbTGW4vTOwIubvGsJlqATWH9CkYAyBK55vv7ZwHj5hwgWdd2WGvwG Ubm3hqu/llx165YndZ4ECuFC8ejjAW0G3p9AbLSNA4r51+wOvxBKRkmnrwIUTYAyqbAY gGGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dnB3YbRslroktKcVWBmtkOUB1kEjE4Aqzh9tCjoW9sA=; b=Bsk0ldypuRmj150RMd18v6qOZXfctUaD3NVEEGqrH/fnGFagcA7RUAjB+lbBGV9V2d 7nJF7eaqf1K7o1lxQF84VuNIcWmbIzsL7CEKHOJQz/+PFYVadAsa8FhDmqJxvxJzzfXZ JtX+OI4jwpZBA/KgNcGlRr48UQ+EBVriWOuCy6eU6+3zxuD39LOSuDvM1fhw7EWTjAHn CrSQL8kHjiQNq6Eb+g3uqUx7ADbUb0JQcLLgktb+lMYNKpf/FHpxcOezqwjq2swrqzl2 XvxdvSYLkHtfM3GN7uDTSX0jp0l6MrNZeC+ixlVGRi7rk/EDyvpJWMPZXK/x9F6mtrDs JxYw== X-Gm-Message-State: APjAAAUkPEviz42VgGnI4rMgkVWj8Y9X08NywqINWRY2Xyjp7koNmAQW PGcjs3v0PoVoSAaOjkp52F+blA== X-Google-Smtp-Source: APXvYqxeVMWKAvVvcMF6nm972He/fdlmMo/3+VBeCasLPa2AoHRCa64fawVhVSsW5qeL9ISZwA3mwQ== X-Received: by 2002:adf:cd88:: with SMTP id q8mr5442082wrj.286.1582908355553; Fri, 28 Feb 2020 08:45:55 -0800 (PST) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id j5sm13406763wrw.24.2020.02.28.08.45.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 08:45:54 -0800 (PST) Date: Fri, 28 Feb 2020 16:45:53 +0000 From: Daniel Thompson To: Colin Ian King Cc: Lee Jones , Jingoo Han , Bartlomiej Zolnierkiewicz , Gyungoh Yoo , Bryan Wu , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] backlight: sky81452: insure while loop does not allow negative array indexing Message-ID: <20200228164553.eojh3hbrymq3tw2d@holly.lan> References: <20200226195826.6567-1-colin.king@canonical.com> <20200227114623.vaevrdwiduxa2mqs@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 27, 2020 at 03:10:43PM +0000, Colin Ian King wrote: > On 27/02/2020 11:46, Daniel Thompson wrote: > > On Wed, Feb 26, 2020 at 07:58:26PM +0000, Colin King wrote: > >> From: Colin Ian King > >> > >> In the unlikely event that num_entry is zero, the while loop > >> pre-decrements num_entry to cause negative array indexing into the > >> array sources. Fix this by iterating only if num_entry >= 0. > >> > >> Addresses-Coverity: ("Out-of-bounds read") > >> Fixes: f705806c9f35 ("backlight: Add support Skyworks SKY81452 backlight driver") > >> Signed-off-by: Colin Ian King > >> --- > >> > >> V2: fix typo in commit subject line > > > > Isn't the correct spelling "ensure"? > > It is. V1 is correct after all. Doh. It wasn't spelt "ensure" in v1... Daniel.