From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9DF6C3F2D4 for ; Sat, 29 Feb 2020 04:49:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7743E246B0 for ; Sat, 29 Feb 2020 04:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582951795; bh=DS3NNAGzQXXPBL6dUXkJQXtASwW/7FOFjDPGY+oNzvw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=R/l+wW4u0uRL/nmvMN7EjIpNqGp3oBpchHGLnWHwN5lUQI/xDIBMaYaqvPLjE4sEa Vz/VG+08Qv0sgxDB02Bv8GbmFBQrxPkzmgCohFThSGLNtvI3bnA6q5Nst9/D6cLzQP UnjGjnRjb9xTJTcgi4fdoA2rN2Pn+V8wlSiarfsU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726783AbgB2Etx (ORCPT ); Fri, 28 Feb 2020 23:49:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:47544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726418AbgB2Etx (ORCPT ); Fri, 28 Feb 2020 23:49:53 -0500 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB45E246AE; Sat, 29 Feb 2020 04:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582951792; bh=DS3NNAGzQXXPBL6dUXkJQXtASwW/7FOFjDPGY+oNzvw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YdpZavzk/Y3olsp8VBNE8OWwrBOZZFKxShVq4DfJ6JhiPPxoPKo8SnZYNzREHoU1H jTA8o1m+SopT3xxVdb+OyQ2VYwULR+K1UbzUCp1wP443MgQDMK+vo/n7AAJXprh9UT mihI3g9tpciq6JMG9Crsr9P6xwWYaLHnFnBvgWLw= Date: Sat, 29 Feb 2020 13:49:47 +0900 From: Masami Hiramatsu To: Jiri Olsa Cc: Adrian Hunter , Peter Zijlstra , Ingo Molnar , Steven Rostedt , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Mark Rutland , Alexander Shishkin , Mathieu Poirier , Leo Yan , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 03/13] kprobes: Add symbols for kprobe insn pages Message-Id: <20200229134947.839096dbc8321cfdca980edb@kernel.org> In-Reply-To: <20200228172004.GI5451@krava> References: <20200228135125.567-1-adrian.hunter@intel.com> <20200228135125.567-4-adrian.hunter@intel.com> <20200228233600.5f5c733584eac08b8a4a2b70@kernel.org> <20200228172004.GI5451@krava> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Feb 2020 18:20:04 +0100 Jiri Olsa wrote: > > BTW, it seems to pretend to be a module, but is there no concern of > > confusing users? Shouldn't it be [*kprobes] so that it is non-exist > > module name? > > note we already have bpf symbols as [bpf] module Yeah, and this series adds [kprobe(s)] and [ftrace] too. I simply concern that the those module names implicitly become special word (rule) and embedded in the code. If such module names are not exposed to users, it is OK (but I hope to have some comments). However, it is under /proc, which means users can notice it. Thank you, -- Masami Hiramatsu