From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E2DC3F2D1 for ; Mon, 2 Mar 2020 10:54:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01E102166E for ; Mon, 2 Mar 2020 10:54:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FhtT68/n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727557AbgCBKyg (ORCPT ); Mon, 2 Mar 2020 05:54:36 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:52876 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727027AbgCBKyg (ORCPT ); Mon, 2 Mar 2020 05:54:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583146474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DS3NWQ9cQZuAYyDOGt+oLTmTRBDkn8Neek7FpfWpHKQ=; b=FhtT68/nbcZELELSV6GEFAr7Hz+S6hVvNLF2F2f1TxBlPpSWXLIVHGV5xVNaS23v6cETLg c+h/wrjORSABIcOUNHiKXJqZpU6YW4Q0t0cgEm2yKUHZCHLVFDbIwPX/EBxmn6Xrq/rGld X2rYMoTmpslbg7n52ynLNZriVILcc00= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-174-wQSFX-slOFi1bUrbflpluA-1; Mon, 02 Mar 2020 05:54:32 -0500 X-MC-Unique: wQSFX-slOFi1bUrbflpluA-1 Received: by mail-qv1-f72.google.com with SMTP id w13so61917qvk.8 for ; Mon, 02 Mar 2020 02:54:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DS3NWQ9cQZuAYyDOGt+oLTmTRBDkn8Neek7FpfWpHKQ=; b=CfGHLTRPEC7u1Z9tMHopX8tVd5BMPiN2krXTxH7NQGWy908n8dP7H+9cuKbDaP9KQL cHbahpUTExgIbc0EBNwwMZu4Im3aGs7BLhNFhiELoVEwNVrLIJVy2BCcW30EYmuiSBw7 e5Kegojnga+3eKboJI2redMqZyFMkaH2+pgnxfJEBycpwrmPJjUN25laNcS+ZkOoHxUQ tf08/pfdR2snijOmWE1fTO3sAyMa15XY2zVwZ0jFDVcHqP02SuLJngrFXApmr3FCn5/y PV+JdvENeB2indSPmu4fdR7uXdkVWgxkermrCJABQsTjyVCbdy5ldw5bSMwKxuIb4a7X O5FQ== X-Gm-Message-State: ANhLgQ1SEx9l3gpehP0iTSCeHG18oO8ryXaPL/1246/ZBhl1RjiDN8Uf R7qLSH3IXjgh0tLR0fLM4zNHY/8x/6xeGRDGBjJRE/PvpR6wLogAP5BIIJ7m4ZJV3tBdTspJ466 6fbXKiBbT/2IxcmKMy9TUkYz4 X-Received: by 2002:a05:620a:16bc:: with SMTP id s28mr1342471qkj.287.1583146472258; Mon, 02 Mar 2020 02:54:32 -0800 (PST) X-Google-Smtp-Source: ADFU+vup8HPdMgwSzdoLfE1pDvNx1J0XvHumaV92Kmmf/VaJEAY+1B7FvFVVmkt1M600jZFlM6U5dg== X-Received: by 2002:a05:620a:16bc:: with SMTP id s28mr1342454qkj.287.1583146471947; Mon, 02 Mar 2020 02:54:31 -0800 (PST) Received: from redhat.com (bzq-79-180-48-224.red.bezeqint.net. [79.180.48.224]) by smtp.gmail.com with ESMTPSA id a187sm9906648qkc.61.2020.03.02.02.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2020 02:54:31 -0800 (PST) Date: Mon, 2 Mar 2020 05:54:26 -0500 From: "Michael S. Tsirkin" To: Yuri Benditovich Cc: Jason Wang , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Yan Vugenfirer , virtio-dev@lists.oasis-open.org Subject: Re: [PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature Message-ID: <20200302055359-mutt-send-email-mst@kernel.org> References: <20200301143302.8556-1-yuri.benditovich@daynix.com> <20200301143302.8556-3-yuri.benditovich@daynix.com> <20200301145811-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 02, 2020 at 10:53:14AM +0200, Yuri Benditovich wrote: > On Sun, Mar 1, 2020 at 9:58 PM Michael S. Tsirkin wrote: > > > > On Sun, Mar 01, 2020 at 04:33:01PM +0200, Yuri Benditovich wrote: > > > RSS (Receive-side scaling) defines hash calculation > > > rules and decision on receive virtqueue according to > > > the calculated hash, provided mask to apply and > > > provided indirection table containing indices of > > > receive virqueues. The driver sends the control > > > command to enable multiqueue and provide parameters > > > for receive steering. > > > > > > Signed-off-by: Yuri Benditovich > > > --- > > > include/uapi/linux/virtio_net.h | 42 +++++++++++++++++++++++++++++++-- > > > 1 file changed, 40 insertions(+), 2 deletions(-) > > > > > > diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h > > > index 19e76b3e3a64..188ad3eecdc8 100644 > > > --- a/include/uapi/linux/virtio_net.h > > > +++ b/include/uapi/linux/virtio_net.h > > > @@ -57,6 +57,7 @@ > > > * Steering */ > > > #define VIRTIO_NET_F_CTRL_MAC_ADDR 23 /* Set MAC address */ > > > > > > +#define VIRTIO_NET_F_RSS 60 /* Supports RSS RX steering */ > > > #define VIRTIO_NET_F_RSC_EXT 61 /* extended coalescing info */ > > > #define VIRTIO_NET_F_STANDBY 62 /* Act as standby for another device > > > * with the same MAC. > > > @@ -70,6 +71,17 @@ > > > #define VIRTIO_NET_S_LINK_UP 1 /* Link is up */ > > > #define VIRTIO_NET_S_ANNOUNCE 2 /* Announcement is needed */ > > > > > > +/* supported/enabled hash types */ > > > +#define VIRTIO_NET_RSS_HASH_TYPE_IPv4 (1 << 0) > > > +#define VIRTIO_NET_RSS_HASH_TYPE_TCPv4 (1 << 1) > > > +#define VIRTIO_NET_RSS_HASH_TYPE_UDPv4 (1 << 2) > > > +#define VIRTIO_NET_RSS_HASH_TYPE_IPv6 (1 << 3) > > > +#define VIRTIO_NET_RSS_HASH_TYPE_TCPv6 (1 << 4) > > > +#define VIRTIO_NET_RSS_HASH_TYPE_UDPv6 (1 << 5) > > > +#define VIRTIO_NET_RSS_HASH_TYPE_IP_EX (1 << 6) > > > +#define VIRTIO_NET_RSS_HASH_TYPE_TCP_EX (1 << 7) > > > +#define VIRTIO_NET_RSS_HASH_TYPE_UDP_EX (1 << 8) > > > + > > > struct virtio_net_config { > > > /* The config defining mac address (if VIRTIO_NET_F_MAC) */ > > > __u8 mac[ETH_ALEN]; > > > @@ -93,6 +105,12 @@ struct virtio_net_config { > > > * Any other value stands for unknown. > > > */ > > > __u8 duplex; > > > + /* maximum size of RSS key */ > > > + __u8 rss_max_key_size; > > > + /* maximum number of indirection table entries */ > > > + __le16 rss_max_indirection_table_length; > > > + /* bitmask of supported VIRTIO_NET_RSS_HASH_ types */ > > > + __le32 supported_hash_types; > > > } __attribute__((packed)); > > > > > > /* > > > @@ -246,7 +264,9 @@ struct virtio_net_ctrl_mac { > > > > > > /* > > > * Control Receive Flow Steering > > > - * > > > + */ > > > +#define VIRTIO_NET_CTRL_MQ 4 > > > +/* > > > * The command VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET > > > * enables Receive Flow Steering, specifying the number of the transmit and > > > * receive queues that will be used. After the command is consumed and acked by > > > @@ -259,11 +279,29 @@ struct virtio_net_ctrl_mq { > > > __virtio16 virtqueue_pairs; > > > }; > > > > > > -#define VIRTIO_NET_CTRL_MQ 4 > > > #define VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET 0 > > > #define VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MIN 1 > > > #define VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MAX 0x8000 > > > > > > +/* > > > + * The command VIRTIO_NET_CTRL_MQ_RSS_CONFIG has the same effect as > > > + * VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET does and additionally configures > > > + * the receive steering to use a hash calculated for incoming packet > > > + * to decide on receive virtqueue to place the packet. The command > > > + * also provides parameters to calculate a hash and receive virtqueue. > > > + */ > > > +struct virtio_net_rss_config { > > > + __le32 hash_types; > > > + __le16 indirection_table_mask; > > > + __le16 unclassified_queue; > > > + __le16 indirection_table[1/* + indirection_table_mask */]; > > > + __le16 max_tx_vq; > > > + __u8 hash_key_length; > > > + __u8 hash_key_data[/* hash_key_length */]; > > > +}; > > > + > > > + #define VIRTIO_NET_CTRL_MQ_RSS_CONFIG 1 > > > + > > > > > > Extra space here. > > Where exactly you want to remove the empty line? > The format here is exactly as in other places: > comment - structure - space - command - space + #define VIRTIO_NET_CTRL_MQ_RSS_CONFIG 1 should be +#define VIRTIO_NET_CTRL_MQ_RSS_CONFIG 1 > > > > > > /* > > > * Control network offloads > > > * > > > -- > > > 2.17.1 > >