From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Rantala, Tommi T. (Nokia - FI/Espoo)" <tommi.t.rantala@nokia.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"pmladek@suse.com" <pmladek@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: LTS "sysrq: Restore original console_loglevel when sysrq disabled"
Date: Mon, 2 Mar 2020 09:03:53 +0100 [thread overview]
Message-ID: <20200302080353.GA1893929@kroah.com> (raw)
In-Reply-To: <563356cd76b666048db40743c169152f4b6efb53.camel@nokia.com>
On Mon, Mar 02, 2020 at 07:42:55AM +0000, Rantala, Tommi T. (Nokia - FI/Espoo) wrote:
> Hi Greg, Sasha,
>
> Can you cherry-pick these two sysrq patches to LTS kernels?
> They're introduced in v5.1-rc1 and should go to all prior LTS versions.
>
>
> commit 075e1a0c50f59ea210561d0d0fedbd945615df78
> Author: Petr Mladek <pmladek@suse.com>
> Date: Fri Jan 11 13:45:15 2019 +0100
>
> sysrq: Restore original console_loglevel when sysrq disabled
>
> The sysrq header line is printed with an increased loglevel
> to provide users some positive feedback.
>
> The original loglevel is not restored when the sysrq operation
> is disabled. This bug was introduced in 2.6.12 (pre-git-history)
> by the commit ("Allow admin to enable only some of the Magic-Sysrq
> functions").
>
>
> commit c3fee60908db4a8594f2e4a2131998384b8fa006
> Author: Petr Mladek <pmladek@suse.com>
> Date: Fri Jan 11 17:20:37 2019 +0100
>
> sysrq: Remove duplicated sysrq message
>
> The commit 97f5f0cd8cd0a0544 ("Input: implement SysRq as a separate
> input
> handler") added pr_fmt() definition. It caused a duplicated message
> prefix in the sysrq header messages, for example:
>
> [ 177.053931] sysrq: SysRq : Show backtrace of all active CPUs
> [ 742.864776] sysrq: SysRq : HELP : loglevel(0-9) reboot(b) crash(c)
>
> Fixes: 97f5f0cd8cd0a05 ("Input: implement SysRq as a separate input
> handler")
>
Both now queued up, thanks.
greg k-h
prev parent reply other threads:[~2020-03-02 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 7:42 Rantala, Tommi T. (Nokia - FI/Espoo)
2020-03-02 8:03 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302080353.GA1893929@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=stable@vger.kernel.org \
--cc=tommi.t.rantala@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome