From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C95EC3F2C6 for ; Tue, 3 Mar 2020 12:30:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 477A820863 for ; Tue, 3 Mar 2020 12:30:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583238614; bh=pThjzpxTrhTiIcabCf/+FOpc02oozOL5XEEVN73LdxY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Al/IMrw1yZeC2wSstAJul726/Ae2C97g4+x0lg1pIynWx33VlM6GeV7vsGeKO6qkA 0h3xmiUfijR5Wr1xgWePVXWMk4ZPnx1GGv3fVVP5i3CU/wM2T+eFRoLXXK54HwNQ8H X5oFi7wAah5JIypTP7cIHPzsR/qh5CL6umnEhSjQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729285AbgCCMaN (ORCPT ); Tue, 3 Mar 2020 07:30:13 -0500 Received: from foss.arm.com ([217.140.110.172]:46372 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727121AbgCCMaN (ORCPT ); Tue, 3 Mar 2020 07:30:13 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 81713FEC; Tue, 3 Mar 2020 04:30:12 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 066563F534; Tue, 3 Mar 2020 04:30:11 -0800 (PST) Date: Tue, 3 Mar 2020 12:30:10 +0000 From: Mark Brown To: Anson Huang Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH] regulator: anatop: Drop error message for -EPROBE_DEFER Message-ID: <20200303123010.GB3866@sirena.org.uk> References: <1583205261-1994-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xgyAXRrhYN0wYx8y" Content-Disposition: inline In-Reply-To: <1583205261-1994-1-git-send-email-Anson.Huang@nxp.com> X-Cookie: Drilling for oil is boring. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xgyAXRrhYN0wYx8y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 03, 2020 at 11:14:21AM +0800, Anson Huang wrote: > devm_regulator_register() could return -EPROBE_DEFER when trying to > get init data and NOT all resources are available at that time, for > this case, error message should NOT be present, the driver will call > probe again later, so drop error message for -EPROBE_DEFER. No, this is not good - it means that if there is some problem the user will not get any information about why the driver is not instantiating and how to fix it. At most lower the message to dev_dbg(). --xgyAXRrhYN0wYx8y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5eTdEACgkQJNaLcl1U h9DP0Af9EBo3Ed3IWJcDJkDD8qmTx/jmBM6AWA11STYC8A1vzwM+VrL+y/SLXSFV fp7s2QPZtWc/ZAb6hXnj6CzYr2T2iOxWvNf23G6lqMrUzMkLWwrUo3RPh9LrHdoU 2ogfGwxtr58v1TlXuQlNzztjl3NDkybE0eTyCmvBX3RGwuStrcoMiSeYfA4NF4sq ybruAa0kXwn+WCOw6VMvNdfv9XI9Gjav4mPVu2GqNNI1oOIbbvFqLDzLLvpbPsJt bmCuQrC59gbvM/Nj7XdVJSQN5PTMDeRlMB2mWPkv66Te3T1MVr7QfKrQf1RSbgvf gvXkLlRfaNgldAl14nclxqggLmFDxQ== =oY7L -----END PGP SIGNATURE----- --xgyAXRrhYN0wYx8y--