From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC59C3F2D1 for ; Tue, 3 Mar 2020 17:10:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51B1A20728 for ; Tue, 3 Mar 2020 17:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583255453; bh=EdRpff7Ggw9f6J9+gqrw6YLTi24c2hIe6q1lIu9QeXk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=JKm+2fpZ8PlBVpqPIQ+7/kUztQLB6H180qJSfPLMzTyWabQLX9yc+yVCf1n6PZ1cr rwcL69vDjJ1MWXksBD8exFdIbfyLErutMzTkgFvWfgYk965B1w4RzZHE8e5rrpCpCN EJ+NGulJwMnBwLfT4CQoOuPm7XCV2w9x4AfKbBcc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729818AbgCCRKw (ORCPT ); Tue, 3 Mar 2020 12:10:52 -0500 Received: from foss.arm.com ([217.140.110.172]:50014 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727198AbgCCRKw (ORCPT ); Tue, 3 Mar 2020 12:10:52 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 925202F; Tue, 3 Mar 2020 09:10:51 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 128593F534; Tue, 3 Mar 2020 09:10:50 -0800 (PST) Date: Tue, 3 Mar 2020 17:10:49 +0000 From: Mark Brown To: Anson Huang Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH] regulator: anatop: Drop min dropout for bypass mode Message-ID: <20200303171049.GI3866@sirena.org.uk> References: <1583245476-8009-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HkMjoL2LAeBLhbFV" Content-Disposition: inline In-Reply-To: <1583245476-8009-1-git-send-email-Anson.Huang@nxp.com> X-Cookie: Drilling for oil is boring. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HkMjoL2LAeBLhbFV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 03, 2020 at 10:24:36PM +0800, Anson Huang wrote: > Some of anatop regulators support bypass mode, and in bypass mode, > minimum dropout is NOT required, the input voltage will be equal to > the output voltage. The minimum dropout value is ONLY necessary for > LDO enabled mode, so drop the minimum dropout for bypass mode to > avoid unexpected high voltage output from PMIC supplies. The goal makes sense but I don't think it makes sense to do this in the driver - changing this without the core knowing is likely to lead to confusion at some point and also I think this behaviour is likely to be the same for every regulator that has a bypass mode (at least if it isn't I'm kind of confused about how it's bypassing, usually the minimum drop is a function of maintaining regulation). Could you look into doing something like this in the core instead please? --HkMjoL2LAeBLhbFV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5ej5gACgkQJNaLcl1U h9C23gf/bha+BF8TIeD6hPRVh2Doz2kjJKrak1meqLCpkFllt0K4GL9QHSddTmgb vrjGFu5CFPdnY9nTE7cAI53PqzGkkl8jOICNxPmXFRmHnddTVkRVpYohC2DV2CIJ Z0sSsrEfR7Y0lsddsLs/4zF8g5kZOhmp+3RyqJPdtu5dZsIaLRxcaoj0BDpYPFtK QC8N1Ef3S5XZdnWioputBbLaEa/4Rq9WTjo6wCb87zRkFs1mIRpEXtXbnLfrPJ3V nKjUmEZpsmxNyBJw6HIlHM8OibaLlzpzwA+6r5geDOiiXtODom3rcW0BmCOn4iQa 8Fkq/y5fKW3tq2xOWn49Uz006me3Mg== =gqK6 -----END PGP SIGNATURE----- --HkMjoL2LAeBLhbFV--